Fix filing status and share button responsiveness#15
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
daphnehanse11
force-pushed
the
codex/fix-button-responsiveness
branch
from
ab7a556 to
09d9ed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.\n\n## Findings\n- Filing status looked non-responsive because selecting a married filing status with one adult was immediately reconciled back to the prior valid status.\n- Copy share link could silently do nothing when the browser denied Clipboard API writes.\n- I also checked add/remove adult, add/remove dependent, reset, advanced inputs, program mode buttons, custom program checkboxes, employer health checkbox, Find cliffs, chart tabs, and chart legend toggles. No other broken buttons found.\n\n## Changes\n- Selecting a married filing status now adds the required second adult row before reconciliation.\n- Share link copy now tries a fallback copy path, shows Copy failed if the browser still blocks it, and reveals the share URL in a readonly field for manual copying.\n- Local Next dev now proxies base-path /api routes to the Python dev API so the controls load while testing.\n\n## Tests\n- npm run test\n- npm run build (rerun with network access for the configured Google font)\n- Browser audit against local Next + Python API dev servers