Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tcomms scripting #9300

Merged

Conversation

Spookerton
Copy link
Member

@Spookerton Spookerton commented Dec 29, 2023

this ancient thing allows various sorts of malicious behavior and has long since been removed from many other codebases

technically a user facing change, but the actual machinery to use it isn't mapped anywhere

Also comsumed tcomms housekeeping and remove /tmp/ since then they're not conflicting/dependent.

@Spookerton Spookerton added the Quality of Life [PR] This improves user experience somehow. label Dec 30, 2023
@Spookerton Spookerton force-pushed the spkrtn/del/remove-tcomms-scripting branch 2 times, most recently from 37877a7 to 59da479 Compare January 17, 2024 13:11
@Spookerton Spookerton added the Refactor The PR heavily modifies or rewrites an existing feature. label Jan 17, 2024
Atermonera
Atermonera previously approved these changes Jan 18, 2024
split some files, merged some files, cleaned some code
removed spurious listening level toggle from relays
@Spookerton
Copy link
Member Author

conflict resolution, no changes

@Atermonera Atermonera merged commit 93d7ad5 into PolarisSS13:master Jan 31, 2024
6 checks passed
@Spookerton Spookerton deleted the spkrtn/del/remove-tcomms-scripting branch January 31, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life [PR] This improves user experience somehow. Refactor The PR heavily modifies or rewrites an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants