Adds a volume channel for system sounds (roundstart, votes, etc) #9177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purpose
I've found always found the roundstart sound to be uncomfortably loud, and this is generally because most sounds in the game use 50 volume as a baseline and that one, like almost all global sounds, uses 100 volume - double that of most sounds use.
details
adds a new volume channel, System, to the volume menu. roundstart sounds, pregame lobby sounds, and vote start sounds are all tied to this channel, and its volume can be controlled like any other channel, allowing them to be made quieter
this is just one way of doing it - it's also possible to adjust the default or to skip the extra channel in favor of just reducing the default volume, but as a stickler for customization I liked the idea of letting folks have fine-grained control over what is purely a clientside thing
byond appears to cap sound volume at 100, so the roundstart sound (mercifully) cannot be made any louder - just quieter
testing
started a buncha rounds on my local server using various settings on the slider. the default should sound unchanged from the current version, but it can be changed in either direction now. I also tried with a guest account having it muted and another account having it normally to make sure the sounds played correctly, but admittedly I don't really have a way of testing it on a large scale, sadly
media
100% volume, the current default:
dreamseeker_LRofx6HkjL.mp4
50% volume:
dreamseeker_txHuLf2j5z.mp4