Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a volume channel for system sounds (roundstart, votes, etc) #9177

Merged

Conversation

Ilysen
Copy link
Contributor

@Ilysen Ilysen commented Jul 27, 2023

purpose

I've found always found the roundstart sound to be uncomfortably loud, and this is generally because most sounds in the game use 50 volume as a baseline and that one, like almost all global sounds, uses 100 volume - double that of most sounds use.

details

adds a new volume channel, System, to the volume menu. roundstart sounds, pregame lobby sounds, and vote start sounds are all tied to this channel, and its volume can be controlled like any other channel, allowing them to be made quieter

this is just one way of doing it - it's also possible to adjust the default or to skip the extra channel in favor of just reducing the default volume, but as a stickler for customization I liked the idea of letting folks have fine-grained control over what is purely a clientside thing

byond appears to cap sound volume at 100, so the roundstart sound (mercifully) cannot be made any louder - just quieter

testing

started a buncha rounds on my local server using various settings on the slider. the default should sound unchanged from the current version, but it can be changed in either direction now. I also tried with a guest account having it muted and another account having it normally to make sure the sounds played correctly, but admittedly I don't really have a way of testing it on a large scale, sadly

media

100% volume, the current default:

dreamseeker_LRofx6HkjL.mp4

50% volume:

dreamseeker_txHuLf2j5z.mp4

@Atermonera Atermonera added the Sounds [PR] This modifies sound assets or sound asset use. label Aug 5, 2023
Copy link
Contributor

@Atermonera Atermonera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little wary of the vote volume, since people have historically complained that it was too quiet.
But I guess this does give people a way to actually change it, so maybe that can be less of an issue in the future.

@Atermonera Atermonera merged commit 1c659d2 into PolarisSS13:master Aug 5, 2023
1 check passed
@Ilysen Ilysen deleted the no-deafening-roundstart-sounds branch August 5, 2023 20:26
@Ilysen
Copy link
Contributor Author

Ilysen commented Aug 5, 2023

if it tends up bein iffy, we can always change it to be on the master channel or cranking up the default volume. either or

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sounds [PR] This modifies sound assets or sound asset use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants