Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidons and Chemistry QOL #9131

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Bidons and Chemistry QOL #9131

wants to merge 17 commits into from

Conversation

hex37
Copy link
Contributor

@hex37 hex37 commented Jun 30, 2023

BIDONS

  • Ports BIDON containers, portable and refillable chemical tanks, from Eris

  • Adds the various BIDON Containers to R&D's protolathe

    • The Basic Bidon has a large storage supply
    • The Advanced Bidon functions as a giant Cryostasis beaker
    • The Trigger Bidon, a potential antag tool, is an advanced bidon that can be set to deactivate its cryostasis component after 2 minutes elapse.
  • Beakers will now attempt to totally empty themselves if used with Disarm intent

@Atermonera Atermonera added Feature The PR adds new functionality in some way. Sprites [PR] This modifies dmi assets or dmi asset use. labels Jul 19, 2023
Copy link
Contributor

@Atermonera Atermonera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long for me to get to. The sprites are... not great, but passable.

code/modules/reagents/holder/holder.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/bidon.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/bidon.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/bidon.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/bidon.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/bidon.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/bidon.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/bidon.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/glass.dm Outdated Show resolved Hide resolved
@Spookerton Spookerton marked this pull request as draft August 14, 2023 15:32
//this is big movable beaker
/obj/structure/reagent_dispensers/bidon
name = "B.I.D.O.N. canister"
desc = "Blue-Ink Dispenser Omnitech-Nanochem. A canister with acid-resistant linings intended for handling big volumes of chemicals."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ater pinged me about this being a bit questionable word salad like a month ago and the suggested replacement was:
Banded Industrial Drum for Organic Nonvolatiles
If Omnitech-Nanochem is a company you want namedropped it should probably be just in the desc and not the acronym.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this marked as resolved, no changes were made?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, forgot to push a name change fix.

@hex37 hex37 requested a review from Atermonera August 26, 2023 00:15
@Atermonera
Copy link
Contributor

@hex37 merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature The PR adds new functionality in some way. Sprites [PR] This modifies dmi assets or dmi asset use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants