-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goosemed #8603
Draft
Atermonera
wants to merge
24
commits into
master
Choose a base branch
from
goosemed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Goosemed #8603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove carbonmob dependencies
Atermonera
added
Feature
The PR adds new functionality in some way.
Refactor
The PR heavily modifies or rewrites an existing feature.
Needs Announcement
The PR and its effects need to be announced to the general playerbase.
Test Merge
[PR] This requires live feedback and may be reverted later.
Needs Documentation
This change is missing wiki or in-game documentation, and will be too difficult to use without any.
labels
May 2, 2022
Deletes mob/living/carbon
12 tasks
Spookerton
added
the
Stale
[PR] This requires additional work and appears abandoned.
label
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
The PR adds new functionality in some way.
Needs Announcement
The PR and its effects need to be announced to the general playerbase.
Needs Documentation
This change is missing wiki or in-game documentation, and will be too difficult to use without any.
Refactor
The PR heavily modifies or rewrites an existing feature.
Stale
[PR] This requires additional work and appears abandoned.
Test Merge
[PR] This requires live feedback and may be reverted later.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look, I write the system, I get to name it. And if I'm rewriting half of mobcode, I'm damn well gonna name it.
Disclaimer: I will likely work on this in fits and spurts in my evenings, as the mood takes me.
Marking for test merge now, because this definitely will need that at some point. Not marking this for staff input, because while it eventually will warrant such, that requires things that actually need feedback. I'm mostly making the PR now to keep track of the weird miscellaneous stuff I'm touching so that I can be sure to test against it. It's not expected to compile for some time yet, seeing as I have to rework both metabolism and ORGANS.
There's a bunch of stuff in surgery/surgery2 where I'm actually sketching out things specific to the README, but I'm making passes over a lot of other mobcode to familiarize myself with what's already present. No I will not break that out into separate PRs, that will in almost certainly every single case just make conflicts for me as I rewrite half of mobcode.
Testing Plan (Describes stuff written in some semblance of completion)
Dev Plan (Specific things, beyond just what's outlined in the README)
/mob/living
?/mob/living/carbon
? (Requires above few)Actual Rework Material (Not exhaustive (yet))