Added all Alcremie forms #1158
Open
Added all Alcremie forms #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the PR. I ping @JRuffs7, he created an issue for this in the past (#1069). And also @Deleca7755 that left a comment there. I hope they can help us with this PR. |
|
It seems fine, like I said I was unsure on If the form numbers would need to be Increased so the new forms can have numbers related to the ones that were already there. I'm not a maintainer, and I thought keeping parity with the code of the game(s) was generally desired, so I don't know If this doesn't matter, the PR Is fine then |
|
Ok! I'll be on vacation for 2 weeks or so and I don't know if I'll be able to merge everything while on vacation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #1069.
There already was 7 forms of Alcremie but they didn't take into account the sweet type. Consequently, I renamed these 7 existing forms to match the new pattern of
alcremie-[type-of-cream]-[type-of-sweet].I then added the missing 56 forms of Alcremie with proper form names for both english and french languages.
At the same time, I created a PR on the sprites project to match these new form names: PokeAPI/sprites#154
Regarding the order of these new forms in the CSV file, I wasn't sure if it was needed to bump all the following forms in order to insert these new forms so I didn't. I assumed it would be OK to consider that all 7 Alcremie forms of a given type of cream could share the same order.
Let me know if it's not a good idea and if we do need to bump the order of all the following forms.