This repository has been archived by the owner on May 24, 2018. It is now read-only.
Fixed to prevent an error #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,8 +53,10 @@ public function onRun($currentTick){ | |||
| } | |||
|
|
|||
| foreach($this->playerList as $player){ | |||
| if($player==null){ | |||
There was a problem hiding this comment.
Please follow the code style.
|
please accept this patch and then fix the whitespace. The plugin is broken (at least on 13) without the patch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can prevent these errors:
2015-09-10 [22:21:15] [Server thread/CRITICAL]: "Could not pass event 'pocketmine\event\player\PlayerJoinEvent' to 'SimpleAuth v1.7.1': Illegal offset type on SimpleAuth\EventListener
2015-09-10 [22:21:15] [Server thread/WARNING]: RuntimeException: "Illegal offset type" (E_WARNING) in "/plugins/SimpleAuth_v1.7.1.phar/src/SimpleAuth/task/ShowMessageTask" at line 42
2015-09-10 [22:21:29] [Server thread/CRITICAL]: Unhandled exception executing command 'register [HIDDEN]' in register: Illegal offset type in unset
2015-09-10 [22:21:29] [Server thread/WARNING]: RuntimeException: "Illegal offset type in unset" (E_WARNING) in "/plugins/SimpleAuth_v1.7.1.phar/src/SimpleAuth/task/ShowMessageTask" at line 46
2015-09-10 [22:21:39] [Server thread/CRITICAL]: "Could not pass event 'pocketmine\event\player\PlayerQuitEvent' to 'SimpleAuth v1.7.1': Illegal offset type in unset on SimpleAuth\EventListener
2015-09-10 [22:21:39] [Server thread/WARNING]: RuntimeException: "Illegal offset type in unset" (E_WARNING) in "/plugins/SimpleAuth_v1.7.1.phar/src/SimpleAuth/task/ShowMessageTask" at line 46
This patch is very easy, but it wastes memory a little.