Dev cli #30
Draft
Dev cli #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse json file that contain informations and variables imported in thr CLI
… / Implemente push function: read .env file and create/modify all variables that not begin with SECURE_ENV_
… / Implemente push function: read .env file and create/modify all variables that not begin with SECURE_ENV_
RezaRahemtola
requested changes
Jun 9, 2023
CLI/main.go
Outdated
Comment on lines
18
to
20
| var ( | ||
| rootFlagSet = flag.NewFlagSet("textctl", flag.ExitOnError) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| var ( | |
| rootFlagSet = flag.NewFlagSet("textctl", flag.ExitOnError) | |
| ) | |
| rootFlagSet := flag.NewFlagSet("textctl", flag.ExitOnError) |
CLI/main.go
Outdated
| vault_actions.Push(client) | ||
| return nil | ||
| }, | ||
| } |
There was a problem hiding this comment.
You can move these commands in their respective files and import them in the main, it will be cleaner as we will add more and more commands in the future
CLI/secure-env.env
Outdated
Comment on lines
1
to
4
| SECURE_ENV_PROJECT_NAME="secure-env" | ||
| SECURE_ENV_HOST="https://secure-env.poc-innovation.com:8200/" | ||
| SECURE_ENV_PORT=8200 | ||
| SECURE_ENV_TOKEN="hvs.NWAqB95aaCepzz7GXVrO43KW" |
There was a problem hiding this comment.
You can remove it from your commit, and rename it .env for a more conventional name
CLI/parse_file/parse_file.go
Outdated
Comment on lines
20
to
21
| err := godotenv.Load("secure-env.env") | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| err := godotenv.Load("secure-env.env") | |
| if err != nil { | |
| if err := godotenv.Load("env"); err != nil { |
CLI/vault_actions/push.go
Outdated
| return variable | ||
| } | ||
|
|
||
| func IsVariableSecureEnvLocal(variable Variable) bool { |
There was a problem hiding this comment.
why do you add an uppercase if it's only used in this file ?
Suggested change
| func IsVariableSecureEnvLocal(variable Variable) bool { | |
| func isVariableSecureEnvLocal(variable Variable) bool { |
CLI/vault_actions/push.go
Outdated
| return result | ||
| } | ||
|
|
||
| func Create_var(data string) Variable { |
CLI/vault_actions/push.go
Outdated
| Value string | ||
| } | ||
|
|
||
| func LinesInFile(fileName string) []string { |
CLI/vault_actions/push.go
Outdated
| } | ||
| return push | ||
| } | ||
|
|
||
| func Push(client *vault.Client) bool { |
There was a problem hiding this comment.
now it's this function that is exported for nothing imo as it's only used in this file
| } | ||
| return screate | ||
| } | ||
|
|
||
| func Screate(name string, secretData map[string]interface{}, client *vault.Client) bool { |
CLI/vault_actions/sdelete.go
Outdated
| } | ||
| return sdelete | ||
| } | ||
|
|
||
| func Sdelete(name string, client *vault.Client) { |
CLI/vault_actions/sget.go
Outdated
| } | ||
| return sget | ||
| } | ||
|
|
||
| func Sget(name string, key string, client *vault.Client) { |
…create function's name since it's used in push.go file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add push function that :
Edit Screate function :
Changes include
Bugfixe on Screate function
New push function
Checklist