Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): increase compatibility of the docker images with arm64 architecture #3396

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jacquesfize
Copy link
Contributor

New PR based entirely from work done in #2825

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (ff20d0e) to head (dab6a84).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3396      +/-   ##
===========================================
+ Coverage    83.96%   83.97%   +0.01%     
===========================================
  Files          122      122              
  Lines         9758     9767       +9     
===========================================
+ Hits          8193     8202       +9     
  Misses        1565     1565              
Flag Coverage Δ
pytest 83.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacquesfize
Copy link
Contributor Author

jacquesfize commented Mar 6, 2025

@MathRdt, j'ai repris le travail que tu avais effectué dans #2825. Ça marche bien :) Par contre, la construction des images prend énormément de temps, tu as rencontré ce problème ?

@MathRdt
Copy link

MathRdt commented Mar 6, 2025

@MathRdt, j'ai repris le travail que tu avais effectué dans #2825. Ça marche bien :) Par contre, la construction des images prend énormément de temps, tu as rencontré ce problème ?

Tu sais ce qui prend du temps exactement ? À l'intuition, peut être que le QEMU joue, vu que tu fais une virtualisation de ton architecture cible.
Donc tu fais du build docker dans une VM émulée par QEMU, dans un runner Docker sur github, sur une VM.
Mais si c'est l'install de librairies ou quoi, y a peut être moyen de cacher le résultat quelque part avec du multi stage docker build ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants