Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiche taxon] Ajout d'option sur la synthèse géographique #3225

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

jules-jean-louis1
Copy link

@jules-jean-louis1 jules-jean-louis1 commented Oct 11, 2024

closes https://github.com/orgs/PnX-SI/projects/20/views/7?pane=issue&itemId=69854886

Description

Ajout d'une option de maillage sur la synthèse géographique.
Ajout d'un tooltip sur la fiche espèce de la synthèse géographique.

Aperçu

Capture d’écran du 2024-10-11 15-13-50

Le développement réalisé s'appuie sur le composant synthese-carte.

areasEnable: boolean;
areasLegend: any;
private areasLabelSwitchBtn;
public featureGroup: any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est public par défault !

@@ -16,29 +28,208 @@ import { TaxonSheetService } from '../taxon-sheet.service';
})
export class TabGeographicOverviewComponent implements OnInit {
observations: FeatureCollection | null = null;
areasEnable: boolean;
areasLegend: any;
private areasLabelSwitchBtn;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

par convention, on préfixe les champs privés par un "_"

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (9c792e4) to head (6133430).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3225      +/-   ##
===========================================
+ Coverage    83.97%   84.00%   +0.02%     
===========================================
  Files          122      122              
  Lines         9719     9736      +17     
===========================================
+ Hits          8162     8179      +17     
  Misses        1557     1557              
Flag Coverage Δ
pytest 84.00% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edelclaux edelclaux force-pushed the feat/species-page/layer-map-meshes branch from 34195ba to cebfa1e Compare October 17, 2024 10:49
@edelclaux edelclaux force-pushed the feat/species-page/layer-map-meshes branch from 18ab22f to 5f7c02e Compare January 30, 2025 17:29
@edelclaux
Copy link
Contributor

Pour moi, c'est tout bonL Tu peux la enlever le "Draft"

@jules-jean-louis1 jules-jean-louis1 marked this pull request as ready for review February 4, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants