-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go async #730
Draft
igalic
wants to merge
46
commits into
main
Choose a base branch
from
go/async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,493
−2,362
Draft
Go async #730
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
9284706
remove csrf for now, so we can update the rest
igalic e52944e
update rocket*; which gets us stuck in dependency conflicts
igalic bb5c2b6
update rocket* everywhere!
igalic ec9b699
convert plume-common to rocket async
igalic 75722ab
rocket does not need decl_macro anymore
igalic fd9764f
plume-common: also make requests async
igalic 909f677
plume-models: convert admin & api-tokens to async
igalic 944f8c4
plume-models: convert api-tokens. use DbConn::from_request() directly
igalic ce119ff
start making PlumeRocket async
igalic 59e5c49
convert plume-models to all async
igalic b515519
start fixing tests in plume-models
igalic 45c335e
"manually" create ETag and Cache-Control headers
igalic 022e037
when using macros!() we need to import the things that they use
igalic 25c5da1
add tokio (0.2) as dependency to further async-ify our FromData code
igalic a3f165f
Use blocking reqwest API in defer
igalic 3472a58
move ClientBuilder into thread, since we cannot Copy it
igalic 87ce3a7
asyncify plume-models: media upload is now async
igalic 8208859
asyncify from_activity calls (i.e.: block_on())
igalic a010025
asyncify reqwest calls (again?)
igalic 8aa99ce
move signature outside the spawning
jebrosen 65b2c38
.await? result from read_to_string()
igalic be8c67e
move reqwest client out of thread spawning
igalic e9c7259
cargo fmt
igalic e4bb73d
cargo clippy
igalic 2c285b9
start async-ifying routes
igalic 43cb9f7
update webfinger
igalic 6fe16c9
upgrade and use futures… then block_on .await in a trait?
igalic 097d0ea
make plume-models async (again)
igalic 3c830ab
move towards using #[rocket::async_trait]
igalic 44ebce5
fix some, break some compiling by adding async/await in front of it
igalic 850b3c1
add async/.await until all our errors are the same:
igalic d2881ee
add async/.await until all our errors are the same: that our Connecti…
igalic 18bb413
add async/.await until all our errors are the same:
igalic 7aabb96
upgrade webfinger everywhere, and implement async
igalic de6bfca
removed a few unused imports
igalic cb1c260
remove an experiment of disabling Send… it makes no sense
igalic 0726375
add another async (and correctly convert followers_count)
igalic 07036b5
upgrade validator: it now uses types! in macros!!
igalic df44200
replace .map().map_err() with a match
igalic cf3708e
make clippy happy by removing unused imports
igalic 492bbb1
make clippy happy with a weird quirk wrt return
igalic 7490567
fix warnings about unused doc comments
igalic 25c40ad
yet another dubious clippy warnings fix re returns
igalic a508a41
remove redundant use statements
igalic 41f97b0
unroll filter_map() to easier .await
igalic b596e77
remove redundant use statements
igalic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
start async-ifying routes
template utils and error routes
commit 2c285b9aca268d2d947bed06e76cb3b1a02cf9c5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this std::fs::read could (should?) be async.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?