Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a patch to fix doctrine/reflection php8 compatibility issue. #49

Open
wants to merge 1 commit into
base: 7.x-1.x
Choose a base branch
from

Conversation

alan-ps
Copy link

@alan-ps alan-ps commented Sep 8, 2022

No description provided.

@alan-ps alan-ps mentioned this pull request Sep 8, 2022
@e0ipso
Copy link
Member

e0ipso commented Sep 8, 2022

👋 Hello!

I am not maintaining this anymore. Would you like to take over the project?

@belambic
Copy link

I get an error trying to use this branch:

Error: Trait "Doctrine\Common\Reflection\Compatibility\ReflectionClass" not found in
/var/www/html/profiles/newmode/modules/contrib/plug/lib/doctrine/common/lib/Doctrine/Common/Reflection/StaticReflectionClass.php,
line 26

@alan-ps
Copy link
Author

alan-ps commented Oct 25, 2022

@belambic plug module depends on registry_autoload and it contains another PHP8 compatibility issue by its turn: https://www.drupal.org/project/registry_autoload/issues/3295376

Without patching registry_autoload module the registry table could break (it will contain incorrect fully qualified class names). As a result we are getting such errors which say us that some class can't be found.

We can either rollback the database and apply appropriate registry_autoload patch and only after that use current changes.

Or:
apply a patch https://git.drupalcode.org/project/registry_autoload/-/merge_requests/1/diffs;
truncate registry and registry_file tables;
run php registry_rebuild.php (see https://www.drupal.org/project/registry_rebuild).

Hope this could help you!

@alan-ps
Copy link
Author

alan-ps commented Oct 25, 2022

@e0ipso sorry for left you comment without an answer. Not sure if I could maintain a project myself and if it make sense at all.

@belambic
Copy link

belambic commented Oct 28, 2022

Thanks @alan-ps , applying the registry_autoload patch fixed it.

I do still see these warnings, but they don't seem to break anything:

Trying to access array offset on value of type null DocParser.php:967 [warning]
Trying to access array offset on value of type null DocParser.php:967 [warning]
Trying to access array offset on value of type null DocParser.php:967 [warning]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants