Adding eraseAppSettings to UpgradeOptions TypeScript type #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMR11
commented
Jul 4, 2025
| @@ -114,6 +114,7 @@ class DeviceUpgrade { | |||
| self.dfuManager = FirmwareUpgradeManager(transport: self.bleTransport!, delegate: self) | |||
| let config = FirmwareUpgradeConfiguration( | |||
| estimatedSwapTime: self.options.estimatedSwapTime, | |||
| eraseAppSettings: self.options.eraseAppSettings, | |||
There was a problem hiding this comment.
This will pass ts argument to the iOS FirmwareUpgradeConfiguration constructor
| @@ -4,4 +4,5 @@ struct UpdateOptions: Record { | |||
| @Field var estimatedSwapTime: TimeInterval = 0 | |||
| @Field var upgradeFileType: Int = 0 | |||
| @Field var upgradeMode: Int? | |||
| @Field var eraseAppSettings: Bool = false | |||
ball-hayden
reviewed
Jul 8, 2025
| @@ -28,6 +28,7 @@ class UpdateOptions : Record { | |||
| @Field val estimatedSwapTime: Int = 0 | |||
| @Field val upgradeFileType: Int = 0 | |||
| @Field val upgradeMode: Int? = null | |||
| @Field val eraseAppSettings: Boolean? = false | |||
There was a problem hiding this comment.
Please can you make sure this is passed through into FirmwareUpgradeManager?
Sure, will do it and update the PR details with the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing TypeScript to pass
eraseAppSettingsas part ofUpgradeOptions, so that we can have more control if we want to erase app settings or notCurrently, there is no way of erasing App settings as part of the MCU manager firmware update.
This is because this is handled by a boolean
eraseAppSettingsand its set tofalse.By allowing it to pass it via
UpgradeOptions, we can have more controlSelf Review:
Smoke Tests: