Fix decompression failures for compressed logs under O_DIRECT direct write mode #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused header <asm/unistd.h> in Util.h
…ere may be a problem of log compression errors that cannot be correctly decompressed. The issue was fixed by modifying the padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compressing log files in the mode of direct write to O-DIECT, there may be a problem of log compression errors that cannot be correctly decompressed. The issue was fixed by modifying the padding.
Problem
The original code erroneously placed a 512-byte padding area at the front of the buffer. This overwrote the data structures written at the front, leading to file corruption and failure in decompression.
Solution
Move the 512-byte padding area to the end of the buffer instead of the front.
Impact
This fixes the file corruption issue and ensures correct decompression.