Even more portability and performance of your code #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roman-Koshelev
force-pushed
the
master
branch
6 times, most recently
from
22a348d to
c2bd293
Compare
POSIX asynchronous I/O is very sub-optimal. They create threads, dynamically allocate memory, and invoke a lot of system calls (which set the signal mask, priority, and more). Additional locks are also possible (if the AIO is using someone else). Moreover, they are not portable.
Apart from portability, it also provides more guarantees (for example, the write system call does not guarantee that the entire buffer will be written, unlike fwrite, which guarantees that the entire buffer will be written without errors).
Roman-Koshelev
force-pushed
the
master
branch
from
c2bd293 to
1ae869f
Compare
|
? |
|
Hey! Can you describe more changes you made? Or provide some benchmark results of improoved performance? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.