-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Parcel #813
base: main
Are you sure you want to change the base?
Conversation
Getting this error, coming from parcel/core: https://github.com/parcel-bundler/parcel/blob/d58e3361ad16c90bb44a2cad8edae31df66c7578/packages/core/core/src/requests/ParcelConfigRequest.js#L209C31-L245
|
7e69c9a
to
7ef1a5b
Compare
Any progress here? It's blocking #1076 |
@seawatts I've started to work on this and have a branch which works for the most part, but it can't really be merged into Might be possible to cut a beta release for it though, but that'd be up to @louisgv. |
# Conflicts: # api/messaging/package.json # api/persistent/package.json # api/selector/package.json # cli/plasmo/package.json # core/parcel-bundler/package.json # core/parcel-bundler/src/create-ideal-graph.ts # core/parcel-compressor-utf8/package.json # core/parcel-core/package.json # core/parcel-core/src/index.ts # core/parcel-core/src/resolve-options.ts # core/parcel-namer-manifest/package.json # core/parcel-optimizer-encapsulate/package.json # core/parcel-optimizer-es/package.json # core/parcel-packager/package.json # core/parcel-resolver-post/package.json # core/parcel-resolver/package.json # core/parcel-runtime/package.json # core/parcel-transformer-inject-env/package.json # core/parcel-transformer-inline-css/package.json # core/parcel-transformer-lab/package.json # core/parcel-transformer-manifest/package.json # core/parcel-transformer-svelte/package.json # core/parcel-transformer-vue/package.json # examples # package.json # packages/framework-shared/package.json # pnpm-lock.yaml
Hi @tbrockman, is it worth picking this back up? |
Hi, it looks like upgrading Parcel to a newer version would resolve many issues, as there has been significant development upstream. Can we come up with a plan for this? Some things to check in order to make this work, or maybe some historic context on how to upgrade it/or how things have been done. cc @louisgv |
Hey, this PR looks like very much needed, as said it can potentially resolve alot of issue relating to @louisgv Do you think this one can be pushed? |
@pippinmole @tbrockman thought? There are a couple of moving parts with the parcel core that I think would be nice to use upstream directly if it works :-? |
Is it possible to upgrade mix and match parcel package (@parcel/*) versions or do we have to keep them all the same? Thinking of an iterative approach to the upgrade since there are a lot of issues upstream |
# Conflicts: # api/messaging/package.json # api/persistent/package.json # api/selector/package.json # cli/create-plasmo/package.json # cli/plasmo/package.json # core/parcel-core/package.json # core/parcel-optimizer-es/package.json # core/parcel-resolver-post/package.json # core/parcel-resolver/package.json # core/parcel-runtime/package.json # core/parcel-transformer-inline-css/package.json # core/parcel-transformer-manifest/package.json # core/parcel-transformer-svelte/package.json # core/parcel-transformer-vue/package.json # package.json # pnpm-lock.yaml
Hey hey! I stopped working on this but https://github.com/tbrockman/plasmo/tree/parcel is available for reference (updates Doesn't look like anything has changed as far as the blocker I ran into on my branch though. When using recursive pnpm commands (i.e, building with-tabs:build: @parcel/core: Failed to resolve '@plasmo-static-common/react' from
with-tabs:build: './with-tabs/.plasmo/tabs/delta-flyer.tsx'
with-tabs:build: /home/tbrockman/workspace/dev/plasmo/examples/with-tabs/.plasmo/tabs/delta-flyer.tsx:4:27
with-tabs:build: 3 |
with-tabs:build: > 4 | import { getLayout } from "@plasmo-static-common/react"
with-tabs:build: > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
with-tabs:build: 5 |
with-tabs:build: 6 | // @ts-ignore
with-tabs:build: @parcel/resolver-default: Cannot find module '@plasmo-static-common/react' At this point I think I lost motivation and just opted to start using |
Details
An initial attempt at upgrading Parcel. Tracking the following blockers:
I need help with:
@parcel\config-default\index.json
parcel-bundler/parcel#9319If you're down to help, feel free to ping me on Discord or in the comment section.
Code of Conduct
Contacts
If your PR is accepted, we will award you with the
Contributor
role on Discord server.To join the server, visit: https://www.plasmo.com/s/d