Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/validation #861

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Hotfix/validation #861

merged 6 commits into from
Dec 30, 2024

Conversation

shyambhongle
Copy link
Contributor

Fixes #

Changes in this pull request:
Validation fixes
Intervention preview fix

@shyambhongle shyambhongle self-assigned this Dec 20, 2024
Copy link
Collaborator

@norbertschuler norbertschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the possible entry of "," instead of "." and it seems to work well for single or multiple trees as well as for editing the values afterwards. I have not tested the other changes.
(btw. I still cannot build the iOS app for the same error as before error: unsupported option '-G' for target 'arm64-apple-ios13.4' (in target 'RNZipArchive' from project 'Pods'))

@shyambhongle
Copy link
Contributor Author

Hi,
The build issue is fixed in the latest version of the zip package, but it requires setting the minimum deployment version to 15.5. Since we are using Expo and the iOS/Android folders are created dynamically, I will need to write a plugin to handle this.
I am currently making the necessary changes in this branch. I think It's better to merge the branch as writing plugin can take some time.

Copy link

@shyambhongle shyambhongle merged commit d3c65dc into develop Dec 30, 2024
1 check passed
@shyambhongle shyambhongle deleted the hotfix/validation branch December 30, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants