-
Notifications
You must be signed in to change notification settings - Fork 18
New implementation for currency on native app #1887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this, but it is very unresponsive.
@mahmed0715 I've shared a video of how it should be in Slack.
…et-org/treecounter-app into feature/user-location
@sagararyal pls see |
@mahmed0715 the flags are not as they should be. the fonts and width also doesn't look as in design I think @ankitecd can take over for design. |
@sagararyal I won't change the number formatting of currencies based on the chosen currency. In Germany I would except the numbers still to be formatted as German numbers even if another currency symbol is appended. |
I am confused: Should there be a border around the search field (and closing button) now or not? (I prefer a border, but that's just my personal feeling.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add missing translation resources.
…et-org/treecounter-app into feature/user-location
@ankitecd |
We will discuss later, now we can push without this one |
We can add icons in the backend ourselves |
I added the EU flag and @sagararyal has distributed it to all CDNs. Unfortunately loading the PNG files of all countries produces quite some traffic. Having the flags locally would be better. |
Update: I added a flag to the backend. @sagararyal would need to copy it to all our CDNs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not knowing about the final design issue of the UI for the search field, I would approve this now. Also I know loading all the flag PNG image isn't optimal.
@sagararyal can you help deciding or solving the last two open issues, so we can merge this PR? |
# Conflicts: # app/locales/en/commonlabels.json
todo:
|
@sagararyal Do you mean sorting by currency symbol or currency name? This would be sorting by currency symbol with German currency names: |
Fix #1896
Fix #1772
Implemented currency for native app. @sagararyal as expected.
menu item on drawer left,
show featured/all currencies
used this as global currency
reflect this change to other places like currency selector in donation process/all plantproject pricess in donation process
if logged in used profile currency everywhere
onupdate the global currency if logged in update profile in db..
Issues:
EUR
as this will be the chosen currency for most of our current users. Maybe @jmiridis can add the European flag to our assets? Maybe there is a nice € symbol in our icon font? Or we just use an emoji like 💶? But an empty space looks like something is missing.