Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Feature/update react native packages #1690

Merged
merged 24 commits into from
Dec 5, 2019

Conversation

norbertschuler
Copy link
Collaborator

@norbertschuler norbertschuler commented Dec 2, 2019

Fixes #1327 and #1111

Changes in this pull request:

  • continued the work of update react native packages #1673
  • updated react-native version
  • iOS and Android using auto-linking - no more react-native link!
  • quick fix on motivation and login captcha
  • fixed permissions request for geolocation
  • some cleanup of package.json
  • removed YouTube component as having problem playing the video, also fixes YouTubePlayer has been released #1655

Compare with https://react-native-community.github.io/upgrade-helper/?from=0.59.8&to=0.61.5

Please checkout this pull request and use the script clean.sh if you have problems with the build as the upgrade of react-native changes a lot of stuff.

@norbertschuler
Copy link
Collaborator Author

norbertschuler commented Dec 2, 2019

  • Still need to fix the issue of screen without navigation in iOS and Android:

Simulator Screen Shot - iPhone 11 - 2019-12-02 at 17 41 22

Simulator Screen Shot - iPhone 11 - 2019-12-02 at 17 41 33

ios/Podfile Outdated Show resolved Hide resolved
@sanjayradadiya
Copy link
Contributor

sanjayradadiya commented Dec 3, 2019

@norbertschuler regarding this UI issue,

It was already there I haven't made any changes to that.
The earlier FAQ page was broken, I have fixed that issue just to make sure the app is not crash.
I am not sure who worked on FAQ page

@norbertschuler
Copy link
Collaborator Author

@norbertschuler regarding this UI issue,

It was already there I haven't made any changes to that.
The earlier FAQ page was broken, I have fixed that issue just to make sure the app is not crash.
I am not sure who worked on FAQ page

So I probably have broken this again with my changes. If you have an idea what I might have done, please help me fix it again.

- react-native-config is not used yet
- tipsi-stripe is missing (in npm-check), but on purpose as I got problem building the Android app with it
@norbertschuler norbertschuler force-pushed the feature/update-react-native-packages branch from f1a03f0 to 3ec5d35 Compare December 3, 2019 15:13
@norbertschuler norbertschuler force-pushed the feature/update-react-native-packages branch from 3ec5d35 to c0937fa Compare December 3, 2019 15:16
@norbertschuler
Copy link
Collaborator Author

The Android APK files have grown from 11 to 18MB because of (1) some fonts added, (2) some native libs as PDF and ImagePicker added and (3) mostly because of the Hermes engine added.

@norbertschuler norbertschuler merged commit 957484c into develop Dec 5, 2019
@norbertschuler norbertschuler deleted the feature/update-react-native-packages branch December 5, 2019 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YouTubePlayer has been released Update react-native to latest version 0.60.x
2 participants