Tax receipt/modify donor data form #2394

sunilsabatp · 2025-01-31T09:38:10Z

Key Features :

Profile Information Section – Users can update their first name, last name, company name, and Tax Identification Number (TIN).
Address List with Selection – Users can select a primary address from a list of saved addresses.
Primary Address Toggle – A checkbox allows users to mark an address as primary.
Edit Address Option – Each address has an edit button for modifications.
Add New Address Button – Enables users to add additional addresses.
Save & Return Button – Saves changes and navigates back to the previous page.

Figma design

Important points:

A donor cannot directly access this page unless they come from the verification page.
If the donor updates any credentials on this page (such as address or name), their profile will also be updated, and the same data will be rendered on the receipt once they click the "Save and Proceed" button.
If the donor updates any credentials on this page (such as address or name), hasDonorDataChanged will be set to true.

To Do :

Merge the feedbacks addressed in the base branch

…tton.

-Prevent users from directly accessing donor contact management. -Move the donor receipt provider to the app level.

… option

…nput component.

vercel · 2025-01-31T09:38:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 24, 2025 11:47am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	⬜️ Ignored (Inspect)			Feb 24, 2025 11:47am
planet-webapp-temp	⬜️ Ignored (Inspect)			Feb 24, 2025 11:47am

coderabbitai · 2025-01-31T09:38:17Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

-added company name field to the donor contact management form

…ckedAddressGuid state - Moved the `isMatchingAddress` helper function to the utils folder for better reusability. - Initialized a new state variable `checkedAddressGuid` to track the selected address. - Updated `useEffect` to check if the receipt address matches the profile address and set `checkedAddressGuid` accordingly. - Updated `<StyledCheckbox>` to use `checkedAddressGuid` for determining the checked state.

…sion

- Implemented onSubmit function to handle profile update based on user type (individual or organization). - Dynamically constructs request body with appropriate fields (firstName, lastName, companyName, tin). - Updates donor receipt data with new profile information, including donor name and address details. - Includes error handling and loading state for data upload. - Redirects to verification page after successful submission.

- introduce a spinner for the loading state - move updateDonorProfile function to the parent component

- added logic for PUT authentication request when donor data has changed - merged common request structure into a single object for both authenticated and unauthenticated requests - incorporated additional dependency checks (address.guid, token, user, contextLoaded)

Added a condition to prevent unauthorized users from accessing the Donor Contact Management page.

-replaced negated && condition with a more readable || condition.

…ing. -Introduced isUserDataChanged to prevent unnecessary profile updates. -Enhanced readability and maintainability.

mohitb35

@sunilsabatp - Please review my feedback

Feedback was addressed

- restrict unauthorized user to access the link - rename EditPermissionDeniedMessage ->EditPermissionDenied - rearrange translation resources -

- Ensure the primary toggle is hidden in the edit address modal when the selected address is already marked as primary.

…rify-email

src/features/user/Settings/EditProfile/AddressManagement/AddAddress.tsx

src/features/user/DonationReceipt/microComponents/DonorContactForm.tsx

src/features/user/Settings/EditProfile/AddressManagement/EditAddress.tsx

…rify-email

…ReceiptData function

mohitb35

LGTM after adding in #2411

…rify-email

…rify-email Tax receipt/verify email

sunilsabatp added 8 commits January 29, 2025 09:50

refactor: rename page and variable

4c4bbb7

feat(ui): add donor contact management layout with header and back bu…

e1721c9

…tton.

feat: Add back button logic

14492d6

-Prevent users from directly accessing donor contact management. -Move the donor receipt provider to the app level.

feat(UI): add text fields for name and address with checkbox and edit…

89e45fe

… option

feat(UI) : add buttons to save data and add new address

6ecefdc

refactor : refactor the donor address form by creating a common FormI…

221b40b

…nput component.

refactor: remove company name filed

6c600d3

feat: integrate address action modals

fd2cb31

sunilsabatp marked this pull request as draft January 31, 2025 09:38

sunilsabatp added the PR: draft label Jan 31, 2025

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup January 31, 2025 09:45 View deployment

sunilsabatp added 7 commits February 1, 2025 10:45

feat: add api to fetch user addresses

4b6774b

-added company name field to the donor contact management form

feat: add validation to ensure address is selected before form submis…

fbdba45

…sion

refactor : donor contact form

89c5b45

- introduce a spinner for the loading state - move updateDonorProfile function to the parent component

fix: ensure address selection updates form state and triggers validation

cf3dd87

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 3, 2025 12:11 View deployment

fix : restrict direct access to Donor Contact Management page

2596e42

Added a condition to prevent unauthorized users from accessing the Donor Contact Management page.

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 4, 2025 05:51 View deployment

sunilsabatp added 2 commits February 4, 2025 11:56

refactor: simplify condition for authentication check

7f0397c

-replaced negated && condition with a more readable || condition.

refactor: optimize donor profile update logic and improve state handl…

e63ad64

…ing. -Introduced isUserDataChanged to prevent unnecessary profile updates. -Enhanced readability and maintainability.

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 5, 2025 09:45 View deployment

refactor : remove useMemo

ad6193d

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 5, 2025 16:11 View deployment

refactor: remove unwanted code

c07b965

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 6, 2025 14:03 View deployment

mohitb35 requested changes Feb 20, 2025

View reviewed changes

sunilsabatp added 7 commits February 20, 2025 11:42

fix: refactor DonationReceiptLayout: Extract ErrorMessage component.

5ffa7fd

- restrict unauthorized user to access the link - rename EditPermissionDeniedMessage ->EditPermissionDenied - rearrange translation resources -

refactor: minor text change

dbb1aa6

refactor: remove unnecessary code

4e1bf48

fix : hide primary toggle in edit modal for primary address

5d36c11

- Ensure the primary toggle is hidden in the edit address modal when the selected address is already marked as primary.

fix: allow access to /verify-receipt-data for non-logged-in users

9177055

fix: check for undefined verification date

8e0f077

Merge branch 'tax-receipt/modify-donor-data-form' into tax-receipt/ve…

05d24a2

…rify-email

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 24, 2025 02:41 View deployment

address the feedback

308076b

sunilsabatp requested a review from mohitb35 February 24, 2025 03:11

mohitb35 reviewed Feb 24, 2025

View reviewed changes

src/features/user/Settings/EditProfile/AddressManagement/AddAddress.tsx Show resolved Hide resolved

mohitb35 reviewed Feb 24, 2025

View reviewed changes

src/features/user/DonationReceipt/microComponents/DonorContactForm.tsx Show resolved Hide resolved

mohitb35 reviewed Feb 24, 2025

View reviewed changes

src/features/user/Settings/EditProfile/AddressManagement/EditAddress.tsx Show resolved Hide resolved

address feedback

35b31d3

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 24, 2025 06:29 View deployment

sunilsabatp and others added 2 commits February 24, 2025 12:00

Merge branch 'tax-receipt/modify-donor-data-form' into tax-receipt/ve…

bf0114a

…rify-email

refactor: rename prevState --> previousData for clarity in format…

ee6a721

…ReceiptData function

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 24, 2025 08:06 View deployment

fix: update operation logic to handle verification date more accurately

ba1b98b

mohitb35 approved these changes Feb 24, 2025

View reviewed changes

Merge branch 'tax-receipt/modify-donor-data-form' into tax-receipt/ve…

ff7386d

…rify-email

sunilsabatp added PR: reviewed-approved and removed PR: unreviewed labels Feb 24, 2025

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 24, 2025 09:04 View deployment

sunilsabatp added 3 commits February 24, 2025 15:18

address feedback

07c060b

refactor: remove the receipt data from session storage after login

e74d954

Merge pull request #2411 from Plant-for-the-Planet-org/tax-receipt/ve…

a3757f5

…rify-email Tax receipt/verify email

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup February 24, 2025 11:47 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tax receipt/modify donor data form #2394

Tax receipt/modify donor data form #2394

sunilsabatp commented Jan 31, 2025 •

edited

Loading

vercel bot commented Jan 31, 2025 •

edited

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mohitb35 left a comment

mohitb35 left a comment

Tax receipt/modify donor data form #2394

Are you sure you want to change the base?

Tax receipt/modify donor data form #2394

Conversation

sunilsabatp commented Jan 31, 2025 • edited Loading

vercel bot commented Jan 31, 2025 • edited Loading

coderabbitai bot commented Jan 31, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mohitb35 left a comment

Choose a reason for hiding this comment

mohitb35 left a comment

Choose a reason for hiding this comment

sunilsabatp commented Jan 31, 2025 •

edited

Loading

vercel bot commented Jan 31, 2025 •

edited

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)