Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release TimeTravel Feature #2392

Merged
merged 35 commits into from
Jan 30, 2025
Merged

Release TimeTravel Feature #2392

merged 35 commits into from
Jan 30, 2025

Conversation

mariahosfeld
Copy link
Contributor

mohitb35 added 30 commits December 6, 2024 12:50
@mohitb35
feat: dummy data + utility for time travel feature
e6895c1
@mohitb35
temp: enables time travel in archive page with hardcoded esri data
59eb993
@mohitb35
chore: installs @maplibre/maplibre-gl-compare
6a7c463
@mohitb35
temp: adds TimeTravel functionality (wip version)
2128657
@mohitb35
feat: integrate tabs to toggle between available map modes
570cfc7 
- enables switching between time travel and field data modes
- 'Satellite Analysis' is currently disabled
@mohitb35
refactor: move icons and TimeTravelDropdown from temp directory
53c33b7
@mohitb35
feat: adds source/year selection for TimeTravel
b6dd818 
- Add error handling with ErrorHandlingContext
- Add loading states and visual feedback
- Improve data validation and map initialization
- Add configurable year/source selection dropdowns
- Add view state syncing with main map
- Optimize performance with proper cleanup and memoization
- Improve TypeScript types and error constants
@mohitb35
Merge branch 'develop' into feature/project-time-travel
89bc536
@mohitb35
refactor: cleanup imports for icons
5206872
@mohitb35
feat: optimize TimeTravel mounting and display logic
f36ccf7 
- mount TimeTravel only when selectedTab = timeTravel for the first time
- unmount TimeTravel only while moving off the single project page
- prevent unnecessary reloads of tiles in comparison maps
@mohitb35
refactor: remove unused state and parameters from SingleProjectView a…
4350519 
…nd zoomInToProjectSite
@mohitb35
Merge branch 'develop' into feature/project-time-travel
664fc10
@mohitb35
feat: allows zoom controls to be visible above time travel
6361355
@mohitb35
feat: pass selectedTab prop to SingleProjectView for conditional rend…
50c7d45 
…ering

- plant locations not shown if selected tab is not field data
@mohitb35
Merge branch 'develop' into feature/project-time-travel
af2731b
@mohitb35
fix: update incorrect icon imports
49d4d98
@mohitb35
feat: fetches and caches esri wayback data for project time travel co…
553d5fb 
…nfig
@mohitb35
feat: update logic to display satellite toggle
7437985
@mohitb35
feat: add intervention dropdown visibility logic for project details …
55512c1 
…page
@mohitb35
fix: makes time travel dropdown text translatable
c77426d
@mohitb35
fix: adjusts styles for time travel dropdown
115aab6
@mohitb35
fix: moves swiper position to 75% from top
6ab716c
@mohitb35
feat: loads time travel tab/component if data sources available
026c844 
- updates structure of ProjectTimeTravelConfig
- adds missing dependency timeTravelConfig for ProjectsMapContext value update
- refactors code for TimeTravel based on updated ProjectTimeTravelConfig structure
- adds conditions to conditionally render MapTabs when more than 1 tab is possible
@mohitb35
fix: prevent time travel view from showing on mobile devices
57b1872
@mohitb35
fix: update Map import to MaplibreMap for consistency
d5bd72f 
- avoids shadowing the global Map object
@mohitb35
fix: add type annotation for SOURCE_LABELS in TimeTravelDropdown
05af2c7
@mohitb35
refactor: breaks up loadLayers function in TimeTravel component
816df46 
- for improved modularity and readability
@mohitb35
refactor: extract map initialization logic into a separate function
b3a25dd
@mohitb35
fix: validate project point geometry before fetching time travel data
8843cc3
@mohitb35
feat: improve accessibility in TimeTravelDropdown
84f1c83
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:06am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
planet-webapp ⬜️ Ignored (Inspect) Jan 30, 2025 10:06am
planet-webapp-temp ⬜️ Ignored (Inspect) Jan 30, 2025 10:06am

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

shyambhongle
shyambhongle approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@shyambhongle shyambhongle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariahosfeld mariahosfeld merged commit b603492 into main Jan 30, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyambhongle shyambhongle shyambhongle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariahosfeld @shyambhongle @mohitb35