Hotfix/map zoom out #2352
Open
Hotfix/map zoom out #2352
+51
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move zoom-out logic to map root file - Use constant variable for flyTo zoom value - Remove braces for single-line callback in 'moveend' event listener
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
mariahosfeld
previously requested changes
Jan 9, 2025
mariahosfeld
dismissed
their stale review
Performance will need to be monitored first.
mariahosfeld
reviewed
Jan 9, 2025
- simplified the logic for setting satellite view based on `singleProject.purpose` and `plantLocations`. - consolidated conditions to set `isSatelliteView` directly based on project purpose and plant location availability.
…te-layer refactor: refactor satellite view logic in useEffect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When visiting a specific plant location via a direct link (e.g., Direct link to plant location), and then using the back button to return to the landing page, the map becomes stuck at an incorrect zoom level and latitude/longitude coordinates. This behavior contradicts the expected behavior set by the
flyTo() function,which is responsible for zooming the map out.Fix: This PR fixes the issue by ensuring that the map zoom level and coordinates reset correctly when navigating back from the plant location.