-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design graph component (CO2 Captured and Canopy Cover) #1984
Open
prachigarg19
wants to merge
30
commits into
develop
Choose a base branch
from
feature/design-capture-graph
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+369
−2
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1213804
add graph
prachigarg19 9b7385e
modify graph
prachigarg19 dd0567a
change stories for graph
prachigarg19 48a56fb
add style for tooltips
prachigarg19 0fba756
changes made:
prachigarg19 1d5fc82
add annotation line
prachigarg19 112cbfb
add title and subtitle
prachigarg19 0773520
make component common
prachigarg19 0b580e9
add interface
prachigarg19 127bf0e
remove unused imports
prachigarg19 4bfc2ed
resolve ts errors
prachigarg19 b877681
add chromatic workflow
prachigarg19 905bef8
add gradient in graph
prachigarg19 0c17009
add property to make tooltip follow cursor
prachigarg19 e26e9fb
add styles for annotation
prachigarg19 af864b8
add translations
prachigarg19 9081299
add useEffect and useState
prachigarg19 ee59f93
fix heading style
prachigarg19 fa4dd15
remove hard coded width
prachigarg19 e88986a
Merge branch 'feature/redesign-explore-btn' into feature/design-captu…
prachigarg19 5b48d1f
replace hardcoded colors and fonts
prachigarg19 32dd91a
fix: fix heading
prachigarg19 466bbf8
refactor: merge base branch,resolve merge conflict
sunilsabatp 338075b
fix: translation issue, code clean up, remove hardcode value
sunilsabatp ae8b71a
feat: story for canopy cover, minor code cleanup
sunilsabatp 4029516
refactor: increase the font-size
sunilsabatp b6227d7
refactor: make text bold
sunilsabatp c7de0b1
feat: dot notation for project launch verticle line
sunilsabatp 09f4a45
feat: include month in the graph tootip
sunilsabatp 314a4e2
feat: reduce stroke dash array
sunilsabatp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
add useEffect and useState
commit 90812994f7b55a712b0ff8c5d4a7b0da6f81d9d0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding values and update dependency array
In the
useEffect
hook, the use of a hardcoded year (2020
) when setting x-axis options can lead to incorrect labeling if the actual years differ. Additionally, the dependency array is empty, which may cause issues ifyears
ort
(translations) change.Apply this diff to use dynamic year values and update the dependency array:
📝 Committable suggestion