-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PlanetCash payments for more types of donations #471
Allow PlanetCash payments for more types of donations #471
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user is logged in, and has an active PlanetCash account, switching to a monthly schedule still shows the option "pay with PC", tested with project empowerment.
- refactors code to extract logic to show `PlanetCashSelector` to `isPlanetCashAllowed` utility function
06e6b2c
to
2890661
Compare
Resolved in 2890661 To avoid excessive changes that could break the planet cash logic, the planet cash selector will be visible but disabled in monthly and yearly frequencies. This is as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue with PlanetCash button for monthly donations has been resolved.
- adds authentication to loadPaymentSetup call (as "planet-cash" gateway is only returned in authenticated call) - adds debouncing while loading payment setup for non planet cash projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good.
Updated logic -
purpose: "trees" | "conservation" | "funds"
with the exception of projects classified asmembership
orendowment
.isGift
and `giftDetails.recipientName = "")For recurring donations, the planet cash selector, if shown (based on other conditions), will be disabled.
As
onBehalf
is not used in the project, checks based on that have been removedPending
/paymentOptions
API response (gateways.planet-cash
should exist)/paymentOptions
API should be authenticated if needed