Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs with Planetcash selector #460

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

mohitb35
Copy link
Contributor

@mohitb35 mohitb35 commented Jan 16, 2024

Bugs fixed

  1. Planetcash toggled on automatically after disabling - introduced by Enable native payments #447
  2. Planetcash switch turned on automatically after updating the amount or editing gift details
  3. Resolves issues with paying into planetcash using native payments - payment failure, incorrect amount after visiting from the Add Balance button while on the project page - by making sure to refresh paymentRequest on every change to country, currency, amount.

Also:

  1. Resolves an issue of jerky layout seen when Google Pay / Apple Pay buttons were present and amount was refreshed.
  2. Enables login to vercel deployments with custom domains (e.g. applepay.pp.eco) without redirecting to the dynamic preview url. This is to be used for testing only, by setting the DISABLE_VERCEL_REDIRECT env to "true"

- planetcash switch auto enabled after disable > resolved
- planetcash switch auto enabled after editing gift/amount > resolved
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
donate-with-planet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 10:47am

Copy link
Contributor

@mariahosfeld mariahosfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works for me as expected.

- ensures amount is always correct
- ensures event handler is always attached
- cleans up event handler on unmount
@mohitb35
Copy link
Contributor Author

@mariahosfeld now planetcash payments using native payment methods also work.

@norbertschuler
Copy link
Collaborator

Everytime I login and pay with my PlanetCash the donation is done, but I do not see a thank you page, but stay on this page where the payment button is greyed out as following - for paydev.pp.eco one gets correctly redirected to a thank you page:

Bildschirmfoto 2024-01-17 um 11 13 31

@mohitb35
Copy link
Contributor Author

verytime I login and pay with my PlanetCash the donation is done, but I do not see a thank you page, but stay on this page where the payment button is greyed out as following - for paydev.pp.eco one gets correctly redirected to a thank you pag

I don't see this issue, it gets correctly redirected. Could you demonstrate this?

@norbertschuler
Copy link
Collaborator

norbertschuler commented Jan 17, 2024

I don't see this issue, it gets correctly redirected. Could you demonstrate this?

It is a different problem of its own which can be solved separatly:

  1. I did a donation before and so reached a page as e.g. https://donate-with-planet-873uy0mu7-planetapp.vercel.app/de?step=thankyou&to=plants-for-life (which step=thankyou as part of the URL)
  2. Lazy as I am I reloaded that page in the browser to show the first page again, but the step=thankyou persisted in the URL.
  3. Doing a PlanetCash payment then results in staying on this screen probably as the software does not redirect to the thank you page as it already is part of the current URL.

@mohitb35 mohitb35 force-pushed the feature/planetcash-auto-enable-bug branch from 152848e to a2d8163 Compare January 17, 2024 10:45
@mariahosfeld mariahosfeld merged commit d720673 into develop Jan 18, 2024
6 checks passed
@mariahosfeld mariahosfeld deleted the feature/planetcash-auto-enable-bug branch January 18, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants