Feat/planet cash topup #307
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@Shreyaschorge Functionally this works properly. I have added some comments for some of the code, please take a look.
| @@ -13,11 +13,11 @@ import { setCountryCode } from "src/Utils/setCountryCode"; | |||
| import { DONATE } from "src/Utils/donationStepConstants"; | |||
|
|
|||
| interface Props { | |||
| projectDetails: Object; | |||
| projectDetails?: Object; | |||
There was a problem hiding this comment.
Codefactor reports an issue here due to using type Object
There was a problem hiding this comment.
Yes I am aware of that.
This will be fixed in #309
| donationStep: any; | ||
| giftDetails: Object; | ||
| isGift: boolean; | ||
| resolvedUrl: any; | ||
| resolvedUrl?: any; |
There was a problem hiding this comment.
Codefactor reports an issue here due to using type any
There was a problem hiding this comment.
This will be fixed in #309
| @@ -28,7 +28,7 @@ interface Props { | |||
| allowTaxDeductionChange: boolean; | |||
| currency: any; | |||
| paymentSetup: any; | |||
| treecount: any; | |||
| treecount?: any; | |||
There was a problem hiding this comment.
Codefactor reports an issue here due to using type any.
There was a problem hiding this comment.
This will be fixed in #309
| const _currentPlanetCashAccount = planetCashAccounts.find((account) => { | ||
| return account.country === _country; | ||
| }); | ||
| if (_currentPlanetCashAccount) { |
There was a problem hiding this comment.
@Shreyaschorge Isn't this redundant?
The useEffect above also calls setCurrentPlanetCashAccount and is dependent on country and planetCashAccounts
There was a problem hiding this comment.
Fixed here 68c8c0e
|
I tested the functionality, works as I expected. |
Changes in this pull request:
to=planetCashin the route, thus providing user with the url likehttp://paydev.pp.eco?to=planetCash&step=donate