refactor: minor refactors to address codefactor feedback

- removes unnecessary `true &&...` expression - refactors onClick handler for currency selector in TreeDonations
Plant-for-the-Planet-org · Dec 3, 2024 · f2574c1 · f2574c1
1 parent 71554b5
commit f2574c1
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 24 deletions.
diff --git a/src/Donations/Components/ContactsForm.tsx b/src/Donations/Components/ContactsForm.tsx
@@ -401,29 +401,27 @@ function ContactsForm(): ReactElement {
             </div>
             <div style={{ width: "20px" }} />
             <div className={"form-field mt-30 flex-1"}>
-              {true && (
-                <Controller
-                  name="zipCode"
-                  control={control}
-                  rules={{
-                    required: t("zipCodeRequired"),
-                    pattern: {
-                      value: postalRegex as RegExp,
-                      message: t("zipCodeInvalid"),
-                    },
-                  }}
-                  render={({ field: { onChange, value, onBlur } }) => (
-                    <MaterialTextField
-                      onChange={onChange}
-                      onBlur={onBlur}
-                      value={value}
-                      label={t("zipCode")}
-                      variant="outlined"
-                      data-test-id="test-zipCode"
-                    />
-                  )}
-                />
-              )}
+              <Controller
+                name="zipCode"
+                control={control}
+                rules={{
+                  required: t("zipCodeRequired"),
+                  pattern: {
+                    value: postalRegex as RegExp,
+                    message: t("zipCodeInvalid"),
+                  },
+                }}
+                render={({ field: { onChange, value, onBlur } }) => (
+                  <MaterialTextField
+                    onChange={onChange}
+                    onBlur={onBlur}
+                    value={value}
+                    label={t("zipCode")}
+                    variant="outlined"
+                    data-test-id="test-zipCode"
+                  />
+                )}
+              />
               {errors.zipCode !== undefined && (
                 <div className={"form-errors"}>{errors.zipCode.message}</div>
               )}

diff --git a/src/Donations/Micros/DonationTypes/TreeDonation.tsx b/src/Donations/Micros/DonationTypes/TreeDonation.tsx
@@ -152,7 +152,7 @@ function TreeDonation({ setopenCurrencyModal }: Props): ReactElement {
           <button
             onClick={() => {
               // Lock the currency/country change if planetCash is active
-              !isPlanetCashActive && setopenCurrencyModal(true);
+              if (!isPlanetCashActive) setopenCurrencyModal(true);
             }}
             className="text-bold text-primary"
             style={{