Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected Caching duration #190

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Corrected Caching duration #190

merged 1 commit into from
Feb 13, 2025

Conversation

rupamkairi
Copy link
Contributor

@rupamkairi rupamkairi commented Feb 12, 2025 •
edited
Loading

Fixes the API caching duration.

1800 seconds → 30 minutes
86400 seconds → 1 day

Screenshot 2025-02-12 at 21 35 03

I also have been noticing even though this updated caching duration works Preview Environment,
With Same env variable values caching duration does not work on the Production Environment

@shyambhongle @sagararyal

@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fire-alert ❌ Failed (Inspect) Feb 12, 2025 4:10pm

@shyambhongle shyambhongle self-requested a review February 13, 2025 04:16
shyambhongle
shyambhongle approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@shyambhongle shyambhongle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupamkairi rupamkairi merged commit dc1477b into develop Feb 13, 2025
2 of 3 checks passed
@rupamkairi rupamkairi deleted the hotfix/fires-caching-correction branch February 13, 2025 04:24
rupamkairi added a commit that referenced this pull request Feb 13, 2025
@rupamkairi
Merging 3 PRs. (#191)
defd1a3 
* Hotfix/fires api cors (#187) (#188)

* Simplified control flow
* Short circuiting OPTIONS call with empty response.

* added filter for syncing important projects (#189)

* Corrected Caching duration (#190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyambhongle shyambhongle shyambhongle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupamkairi @shyambhongle