Feature/rest endpoint fires #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rupamkairi
force-pushed
the
feature/REST-endpoint-fires
branch
from
088eb48 to
0bf8c6c
Compare
|
Deployment failed with the following error: |
Versioning & GeoJSON return Api versioning introduced (path /v1, /v2). Fires are returned as GeoJSON. handling query parameter span fixed output format file moved, removes /rest segment accounted for remoteIds & CORS.
rupamkairi
force-pushed
the
feature/REST-endpoint-fires
branch
from
f4b2e05 to
fc67b97
Compare
rupamkairi
force-pushed
the
feature/REST-endpoint-fires
branch
from
4065c0b to
0e35837
Compare
Caching setting by environment variables Caching env variable
rupamkairi
force-pushed
the
feature/REST-endpoint-fires
branch
from
9860857 to
98b7954
Compare
sagararyal
reviewed
Jan 14, 2025
apps/server/src/env.mjs
Outdated
| @@ -38,7 +38,8 @@ const server = z.object({ | |||
| CRON_KEY: z.string().optional(), | |||
| NEXT_PUBLIC_LOGTAIL_SOURCE_TOKEN: z.string().optional(), | |||
| WHATSAPP_ENDPOINT_URL: z.string(), | |||
| WHATSAPP_ENDPOINT_AUTH_TOKEN: z.string() | |||
| WHATSAPP_ENDPOINT_AUTH_TOKEN: z.string(), | |||
| PUBLIC_API_CACHING: z.string().optional(), | |||
|
Should plan for abstraction of api if we add more in future, but looks good.
|
Will do the env schema change. But do you think the abstraction can go in separate PR, so this can be tested in integration. |
sagararyal
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest api endpoint for fires by remoteId or siteId is created. This lists fires for the sites for last 7 Days (default span).
endpoint at
/api/v1/fires.Browser & CDN Caching for a 2 Hours, with SWR (
stale-while-revalidation) for 2 Hours.Fires data is returned in GeoJSON.
Authorisation is not needed since it is Public API.
Following is a screenshot for Data & Output
@sagararyal