Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Slice Convention #161

Merged
merged 5 commits into from
Mar 29, 2024
Merged

New Slice Convention #161

merged 5 commits into from
Mar 29, 2024

Conversation

dhakalaashish
Copy link
Contributor

@dhakalaashish dhakalaashish commented Mar 11, 2024

This PR introduces a new slice convention to the FireAlert, featuring three main updates. It expands old slices, updates the create-postgis-triggers.sql script, and includes an updated geoslice.png. Specifically, slices 1, 7, and 8 have been systematically renumbered to 10, 70, and 80 respectively, to allow for more granular segmentation. Furthermore, slices 2,3,4, 5, and 6 (which normally has large fire volume) underwent a more intricate division, being split into three vertical sub-slices each. This change ensures that the fire-alert detection logic will work seamlessly for previously dense slices.

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fire-alert ❌ Failed (Inspect) Mar 21, 2024 0:27am

Copy link

@mohitb35 mohitb35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhakalaashish dhakalaashish removed the request for review from sagararyal March 29, 2024 07:51
@dhakalaashish dhakalaashish merged commit 453316c into develop Mar 29, 2024
3 of 5 checks passed
@dhakalaashish dhakalaashish deleted the feature/expand-slice-4and5 branch March 29, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants