Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nativeapp build issues #158

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add auth0_domain in strings.xml and use .env.production
dhakalaashish committed Mar 4, 2024
commit acb8c4998c87a34d3a00825eb414ff8fa71cbc51
4 changes: 2 additions & 2 deletions apps/nativeapp/android/app/build.gradle
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ apply plugin: "com.android.application"
apply plugin: "com.facebook.react"
project.ext.envConfigFiles = [
staging : ".env.staging",
release: ".env",
release: ".env.production",
develop : ".env",
]
apply from: project(':react-native-config').projectDir.getPath() + "/dotenv.gradle"
@@ -114,7 +114,7 @@ android {
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 4
versionName "1.2"
manifestPlaceholders = [auth0Domain: "accounts.plant-for-the-planet.org", auth0Scheme: "${applicationId}"]
manifestPlaceholders = [auth0Domain: "@string/AUTH0_DOMAIN", auth0Scheme: "${applicationId}"]
}

splits {
6 changes: 6 additions & 0 deletions apps/nativeapp/android/app/src/debug/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<resources>
<!-- Application name -->
<string name="app_name">FireAlert</string>
<!-- Auth0 Domain Configuration -->
<string name="AUTH0_DOMAIN">accounts.plant-for-the-planet.org</string>
</resources>
3 changes: 3 additions & 0 deletions apps/nativeapp/android/app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<resources>
<!-- Application name -->
<string name="app_name">FireAlert</string>
<!-- Auth0 Domain Configuration -->
<string name="AUTH0_DOMAIN">accounts.plant-for-the-planet.org</string>
</resources>
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<resources>
<!-- Application name -->
<string name="app_name">FireAlert</string>
<!-- Auth0 Domain Configuration -->
<string name="AUTH0_DOMAIN">accounts.plant-for-the-planet.org</string>
</resources>