Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WhatsApp to NativeApp #157

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Conversation

dhakalaashish
Copy link
Contributor

@dhakalaashish dhakalaashish commented Feb 22, 2024

This PR adds WhatsApp to nativeapp and updates the server implementation as well. It also upgrades react-native-auth0 from v2 to v3.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fire-alert ❌ Failed (Inspect) Feb 27, 2024 10:03am

Copy link

@mohitb35 mohitb35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhakalaashish I've requested some minor changes. And raised some points of clarification.

- Comment out handleGeoStationary code
- Remove conditional check for sms toast
- Rename EXCLUDED_COUNTRIES
@dhakalaashish dhakalaashish requested review from mohitb35 and removed request for shyambhongle February 27, 2024 09:38
@dhakalaashish
Copy link
Contributor Author

@mohitb35 Thank you for your feedback. I've made most of the suggested changes, but retained some for correctness.

Copy link

@mohitb35 mohitb35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once conflicts are resolved

@dhakalaashish dhakalaashish merged commit 10608f8 into develop Feb 27, 2024
2 of 5 checks passed
@dhakalaashish dhakalaashish deleted the feature/add-whatsapp-nativeapp branch February 27, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants