Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db-cleanup #106

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Fix db-cleanup #106

merged 3 commits into from
Dec 11, 2023

Conversation

dhakalaashish
Copy link
Contributor

@dhakalaashish dhakalaashish commented Dec 10, 2023

This branch addresses improvements/fixes in the db-cleanup cron job. The updates include:

  1. SiteAlert Deletion Adjustment: Now, old SiteAlerts are purged based on their eventDate rather than the deletedAt attribute.
  2. Notification Retention: The process no longer removes Notifications as part of the database cleanup.
  3. AlertMethod Deletion: AlertMethods that are soft-deleted for over 7 days are now permanently removed in the cleanup process. In the alertMethod router, for the db-cleanup, some adjustments were made:
    a. Soft-deleted AlertMethods can be reinstated within 7 days post-deletion, provided the creation threshold isn't exceeded.
    b. The count for the creation cap now considers only active AlertMethods, excluding any that are soft-deleted.

Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fire-alert ❌ Failed (Inspect) Dec 10, 2023 2:00pm

@sagararyal sagararyal merged commit 9ba2343 into main Dec 11, 2023
@sagararyal sagararyal deleted the hotfix/fix-db-cleanup branch December 11, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants