-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parsing of file names more robust #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID}
)
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID}
)
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID}
)
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID}
)
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID}
)
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID}
)
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Try to make the logic for parsing strings (and file names) from TAR headers more robust:
utf8
)toString()
method; that is, pass it the offset to be printed