Import buffer from npm modules explicitly #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official docs (https://github.com/feross/buffer) suggest: > To depend on this module explicitly (without browserify), require it like > this: > var Buffer = require('buffer/').Buffer // note: the trailing slash is important! > To require this module explicitly, use require('buffer/') which tells the > node.js module lookup algorithm (also used by browserify) to use the npm > module named buffer instead of the node.js core module named buffer!
adamdupuis
approved these changes
Oct 24, 2023
![gitstream-cm[bot]](https://avatars.githubusercontent.com/in/230441?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID})
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
There was a problem hiding this comment.
This PR is missing a reference to Jira ticket:
-
Jira ticket ID should be appended to the PR title
-
Jira ticket URL should be added as a list item in the Related section (
- https://planitar.atlassian.net/browse/{ID})
Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official docs (https://github.com/feross/buffer) suggests: