hdx: Fixes for 1d luts in HdxColorCorrectionTask #3419
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This fixes a couple of issues in HdxColorCorrectionTask for users of 1d luts. We started to notice a
TF_VERIFY()
failure and a mostly-black/uninitialized viewport in usdview when we upgraded to OCIO 2.2 (VFX CY2023).TF_VERIFY()
check._TextureSamplerDesc
. I was findingfloat4AdaptedLutValues
was only conditionally initialized based on the activeHgiFormat fmt
.I realize I've left some of the checklist undone but mostly just checking on interest.
Fixes Issue(s)
Checklist
testing guidelines)
Contributor License Agreement instructions)