Merge pull request #582 from Piwigo/3.2.3

Version 3.2.3 — Bug fixes
Piwigo · Oct 17, 2024 · 74e0070 · 74e0070
2 parents 233431a + 41f637e
commit 74e0070
Show file tree

Hide file tree

Showing 213 changed files with 1,956 additions and 1,474 deletions.
diff --git a/Supporting Targets/piwigoScreenshots/piwigoScreenshots.swift b/Supporting Targets/piwigoScreenshots/piwigoScreenshots.swift
@@ -43,32 +43,81 @@ class piwigoScreenshots: XCTestCase {
         let deviceType = UIDevice().modelName
         sleep(3);
 
-        // Screenshot #1: swipe left and reveal album actions
-        var index = 1
-        if deviceType.hasPrefix("iPad") {
-            index = 7
+        // Settings
+        let withAlbumDescriptions = false
+
+        // Screenshot #1:
+        if withAlbumDescriptions {
+            // Swipe left to reveal album actions when displaying albums with description
+            var index = 1
+            if deviceType.hasPrefix("iPad") {
+                index = 7
+            }
+            let collectionCell = app.collectionViews.children(matching: .cell).element(boundBy: index)
+            let tableQuery = collectionCell.children(matching: .other).element.tables.element(boundBy: 0)
+            sleep(4);
+            tableQuery.swipeLeft()
         }
-        let collectionCell = app.collectionViews.children(matching: .cell).element(boundBy: index)
-        let tableQuery = collectionCell.children(matching: .other).element.tables.element(boundBy: 0)
-        sleep(4);
-        tableQuery.swipeLeft()
         snapshot("Image01")
 
         // Screenshot #2: collection of images
         app.collectionViews.children(matching: .cell).element(boundBy: 2).tap()
         sleep(2);
         if deviceType.hasPrefix("iPhone") {
-            app.collectionViews.children(matching: .cell).element(boundBy: 2).swipeUp()
-            sleep(2);
+            if withAlbumDescriptions {
+                app.collectionViews.children(matching: .cell).element(boundBy: 2).swipeUp()
+                sleep(2);
+            } else {
+                switch deviceType {
+                case "iPhone SE (1st generation)":                          // 4-inch
+                    for _ in 1...2 {
+                        app.collectionViews.firstMatch.swipeUp(velocity: 200)
+                        sleep(1)
+                    }
+                case "iPhone SE (3rd generation)":                          // 4.7-inch
+                    for _ in 1...2 {
+                        app.collectionViews.firstMatch.swipeUp(velocity: 200)
+                        sleep(1)
+                    }
+                case "iPhone 8 Plus":                                       // 5.5-inch
+                    for _ in 1...2 {
+                        app.collectionViews.firstMatch.swipeUp(velocity: 200)
+                        sleep(1)
+                    }
+                case "iPhone 14":                                           // 5.8-inch
+                    for _ in 1...2 {
+                        app.collectionViews.firstMatch.swipeUp(velocity: 200)
+                        sleep(1)
+                    }
+                case "iPhone 14 Pro":                                       // 6.1-inch
+                    for _ in 1...2 {
+                        app.collectionViews.firstMatch.swipeUp(velocity: 200)
+                        sleep(1)
+                    }
+                case "iPhone 14 Plus":                                      // 6.5-inch
+                    for _ in 1...2 {
+                        app.collectionViews.firstMatch.swipeUp(velocity: 200)
+                        sleep(1)
+                    }
+                case "iPhone 15 Pro Max":                                   // 6.7-inch
+                    for _ in 1...2 {
+                        app.collectionViews.firstMatch.swipeUp(velocity: 200)
+                        sleep(1)
+                    }
+                default:
+                    break
+                }
+            }
         }
         snapshot("Image02")
-
+
+        /*
         // Screenshot #3: image previewed
         // https://developer.apple.com/help/app-store-connect/reference/screenshot-specifications
         app.collectionViews.cells["Clos de Vougeot"].tap()
         sleep(3)
         switch deviceType {
-        case "iPhone SE":                                           // 4-inch
+        case "iPhone SE (1st generation)":                          // 4-inch
             app.images.element(boundBy: 0).pinch(withScale: 1.1, velocity: 2.0)
             sleep(1)
             app.images.element(boundBy: 0).tap()
@@ -127,7 +176,7 @@ class piwigoScreenshots: XCTestCase {
         app.navigationBars.buttons.element(boundBy: 0).tap()
         sleep(2)                        // Leave time for animation
         switch deviceType {
-        case "iPhone SE":                                           // 4-inch
+        case "iPhone SE (1st generation)":                          // 4-inch
             for _ in 1...6 {
                 app.collectionViews.firstMatch.swipeUp(velocity: 200)
                 sleep(1)
@@ -196,7 +245,7 @@ class piwigoScreenshots: XCTestCase {
         app.buttons["Select"].tap()
         sleep(1)
         switch deviceType {
-        case "iPhone SE":                                           // 4-inch
+        case "iPhone SE (1st generation)":                          // 4-inch
             app.collectionViews.children(matching: .cell).element(boundBy: 8).tap()
             app.collectionViews.children(matching: .cell).element(boundBy: 9).tap()
             app.collectionViews.children(matching: .cell).element(boundBy: 12).tap()
@@ -278,7 +327,7 @@ class piwigoScreenshots: XCTestCase {
         app.navigationBars["editParams"].buttons["Cancel"].tap()
         sleep(1)                        // Leave time for animation
         switch deviceType {
-        case "iPhone SE":                                           // 4-inch
+        case "iPhone SE (1st generation)":                          // 4-inch
             for _ in 1...6 {
                 app.collectionViews.firstMatch.swipeDown(velocity: 200)
                 sleep(1)
@@ -329,7 +378,7 @@ class piwigoScreenshots: XCTestCase {
         app.collectionViews.cells["Hotel de Coimbra"].tap()
         sleep(2)
         switch deviceType {
-        case "iPhone SE",                                           // 4-inch
+        case "iPhone SE (1st generation)":                          // 4-inch
              "iPhone SE (3rd generation)",                          // 4.7-inch
              "iPhone 8 Plus",                                       // 5.5-inch
              "iPhone 14",                                           // 5.8-inch
@@ -363,7 +412,7 @@ class piwigoScreenshots: XCTestCase {
         app.navigationBars.buttons.element(boundBy: 0).tap()
         sleep(2)                        // Leave time for animation
         switch deviceType {
-        case "iPhone SE",                                           // 4-inch
+        case "iPhone SE (1st generation)":                          // 4-inch
              "iPhone SE (3rd generation)",                          // 4.7-inch
              "iPhone 8 Plus",                                       // 5.5-inch
              "iPhone 14",                                           // 5.8-inch
@@ -458,5 +507,6 @@ class piwigoScreenshots: XCTestCase {
         app.tables["settings"].firstMatch.swipeUp(velocity: 200)
         sleep(2)                        // Leave time for animation
         snapshot("Image10")
+        */
     }
 }
diff --git a/fastlane/Snapfile b/fastlane/Snapfile
@@ -48,14 +48,14 @@ devices([
 # "iPhone 8 Plus",							# 5.5-inch  iOS 16.4
 # "iPhone 14",								# 5.8-inch
 # "iPhone 13 Pro",							# Wiki
-# "iPhone 14 Pro",							# 6.1-inch
+# "iPhone 14 Pro",							# 6.3-inch
 # "iPhone 14 Plus",							# 6.5-inch
-# "iPhone 15 Pro Max",						# 6.7-inch
+# "iPhone 15 Pro Max",						# 6.9-inch
 # "iPad Pro (9.7-inch)",					# 9.7-inch  iOS 16.4
 # "iPad Pro (10.5-inch)",					# 10.5-inch
-# "iPad Pro (11-inch) (4th generation)",	# 11-inch
 # "iPad Pro (12.9-inch) (2nd generation)",	# 12.9-inch
- "iPad Pro (12.9-inch) (6th generation)"	# 12.9-inch
+"iPad Pro (11-inch) (4th generation)",	# 11-inch
+"iPad Pro (12.9-inch) (6th generation)"	# 13-inch
 ])
 
 # ["pt", "pt_BR"] # Portuguese with Brazilian locale
@@ -83,16 +83,19 @@ test_without_building(true)
 output_directory("fastlane/screenshots")
 concurrent_simulators(true)
 skip_open_summary(true)
-number_of_retries(1)
+number_of_retries(0)
 
-# Command below fails with iOS +16.1, 17.x:
-#override_status_bar(true)
+# Command below fails with iOS +16.1, 17.x, 18.x:
+# override_status_bar(true)
 # So use SimulatorStatusMagic to configure iOS 16+ simulators
 # See https://github.com/shinydevelopment/SimulatorStatusMagic
 # iOS 16+: Install the SimulatorStatusMagic app in the simulator
 #          and apply the configuration
 # iOS 17+: Compile library with Xcode
-#          Launch the iOS 17+ simulator to configure (piwigo scheme)
+#          Launch the iOS 17+ simulator (piwigo scheme), stop app
+#          Execute: ../SimulatorStatusMagic/build_and_inject.sh booted
+# iOS 18+: Compile library with Xcode
+#          Launch the iOS 18+ simulator (piwigo scheme), stop app
 #          Execute: ../SimulatorStatusMagic/build_and_inject.sh booted
 
 # clear_previous_screenshots(true)

diff --git a/fastlane/metadata/da/release_notes.txt b/fastlane/metadata/da/release_notes.txt
@@ -1,4 +1 @@
-• Vedtager album foto sortering muligheder
-• Tilføjer on-the-fly foto sortering muligheder
-• Tilføjer rotation af uploadede fotos (kræver rotateImage plugin)
-• Fejlrettelser
+Fejlrettelser
diff --git a/fastlane/metadata/de-DE/release_notes.txt b/fastlane/metadata/de-DE/release_notes.txt
@@ -1,4 +1 @@
-• Übernimmt die Sortieroptionen für Albenfotos
-• Fügt Optionen für die fliegende Sortierung von Fotos hinzu
-• Rotation der hochgeladenen Fotos (erfordert das rotateImage-Plugin)
-• Fehlerbehebungen
+Fehlerbehebungen
diff --git a/fastlane/metadata/en-US/release_notes.txt b/fastlane/metadata/en-US/release_notes.txt
@@ -1,4 +1 @@
-• Adopts album photo sorting options
-• Adds on-the-fly photo sorting options
-• Adds rotation of uploaded photos (requires the rotateImage plugin)
-• Bug fixes
+Bug fixes
diff --git a/fastlane/metadata/es-ES/release_notes.txt b/fastlane/metadata/es-ES/release_notes.txt
@@ -1,4 +1 @@
-• Adoptadas opciones de clasificación de las fotografías de un álbum
-• Añadidas opciones de clasificación de fotografías sobre la marcha
-• Añadida rotación de fotos cargadas
-• Corrección de errores
+Corrección de errores
diff --git a/fastlane/metadata/fr-FR/release_notes.txt b/fastlane/metadata/fr-FR/release_notes.txt
@@ -1,4 +1 @@
-• Adopte les options de tri des photos des albums
-• Ajoute des options de tri des photos à la volée
-• Ajoute la rotation des photos téléchargées (nécessite le plugin rotateImage)
-• Corrections de bugs
+Correction de bugs
diff --git a/fastlane/metadata/hu/release_notes.txt b/fastlane/metadata/hu/release_notes.txt
@@ -1,4 +1 @@
-• Elfogadta az album fotók rendezési lehetőségeit
-• Függőleges fotóválogatási lehetőségek hozzáadása
-• Hozzáadja a feltöltött fényképek forgatását
-• Hibajavítások
+Hibajavítások
diff --git a/fastlane/metadata/it/release_notes.txt b/fastlane/metadata/it/release_notes.txt
@@ -1,4 +1 @@
-• Adotta opzioni di ordinamento foto album
-• Aggiunge opzioni di ordinamento foto al volo
-• Aggiunge la rotazione delle foto caricate (richiede il plugin rotateimage)
-• Correzioni di bug
+Correzioni di bug
diff --git a/fastlane/metadata/ja/release_notes.txt b/fastlane/metadata/ja/release_notes.txt
@@ -1,4 +1 @@
-• アルバム写真の並べ替えオプションを採用
-• オンザフライ写真並べ替えオプションの追加
-• アップロードした写真の回転機能を追加
-• バグ修正
+• バグの修正
diff --git a/fastlane/metadata/nl-NL/release_notes.txt b/fastlane/metadata/nl-NL/release_notes.txt
@@ -1,4 +1 @@
-• Voegt albumfoto sortering opties
-• Voegt op-the-fly foto sortering opties
-• Voegt rotatie van geüploade foto's toe (vereist de rotateImage plugin)
-• Foutjes verbeterd
+Foutjes verbeterd
diff --git a/fastlane/metadata/pl/release_notes.txt b/fastlane/metadata/pl/release_notes.txt
@@ -1,4 +1 @@
-• Można dopasować opcje sortowania zdjęć w albumie
-• Dodaje opcje sortowania zdjęć w locie
-• Dodaje możliwość obracania przesyłanych zdjęć
-• Poprawki błędów
+Poprawki błędów
diff --git a/fastlane/metadata/review_information/notes.txt b/fastlane/metadata/review_information/notes.txt
@@ -1,6 +1,6 @@
-This version adopts the album sorting options of the web UI, introduces an option for sorting photos on-the-fly and a command for rotating photos already uploaded to the Piwigo server. The MBProgressHUD library has also been removed and the app now uses no third party library.
+This version brings a command for deleting a selection of photos/videos stored in the device and expands or adds contextual menus for selecting, sharing, deleting or uploading photos. It also fixes the bugs listed in the TestFlight section.
 
-Here is the address of the server requiring the above credentials and allowing to test all functionalities: https://piwigo.lelievre-berna.net/Dev/
+Here is the address of the server requiring the above credentials and allowing to test all functionalities: https://piwigo.lelievre-berna.net/15.x/
 And here are servers you can try without credentials: https://raia.com, https://www.neilfitzgeraldphoto.co.nz/gallery, http://www.dongshawhwei.com/photos.
 
 The privacy policy is provided in the app in Chinese (Simplified), Danish, Dutch,  English, French, German, Hungarian, Indonesian, Italian, Japanese, Polish, Russian, Spanish and Swedish.
diff --git a/fastlane/metadata/ru/release_notes.txt b/fastlane/metadata/ru/release_notes.txt
@@ -1,4 +1 @@
-• Принимает сортировку фото альбома
-• Добавляет параметры сортировки на лету
-• Добавляет поворот загруженных фотографий (требуется плагин rotateImage)
-• Исправления ошибок
+Исправления ошибок
diff --git a/fastlane/metadata/sv/release_notes.txt b/fastlane/metadata/sv/release_notes.txt
@@ -1,4 +1 @@
-• Antar sorteringsalternativ för albumfoto
-• Lägger till foton i farten sorteringsalternativ
-• Lägger till rotation av uppladdade bilder (kräver rotateImage plugin)
-• Felrättelser
+Buggfixar
diff --git a/fastlane/metadata/zh-Hans/release_notes.txt b/fastlane/metadata/zh-Hans/release_notes.txt
@@ -1,4 +1 @@
-• 通过相册照片排序选项
-• 添加实时照片排序选项
-• 增加上传照片的旋转(需要 rotateImage 插件)
-• Bug 修复
+小错误修复和界面改进
diff --git a/fastlane/metadata/zh-Hant/release_notes.txt b/fastlane/metadata/zh-Hant/release_notes.txt
@@ -1,4 +1 @@
-• 採用相簿圖片旋轉選項
-• 添加即時(on-the-fly)圖片排序選項
-• 新增旋轉上傳圖片的功能
-• 錯誤修正
+小型錯誤修正及介面改進