Improve import-all functionality #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
force-pushed
the
import-all
branch
6 times, most recently
from
b8c044b
to
2a486c9
Compare
samwilson
force-pushed
the
import-all
branch
3 times, most recently
from
dd90fac
to
faa4685
Compare
samwilson
changed the title
|
I think the last thing to fix here is a better error message for when it times out downloading from Flickr. Unfortunately, I can't replicate that error... I'll try from a separate machine soon. Should it retry? Should we slow the importing process down? It's easy enough to run the import again, I figure, so maybe it's just a matter of catching the error to make it look nicer, and logging it for future reference. Sound okay? |
This switches the import-all function to work with any number of images and without timing out by paging through a user's photos and importing each photo. The API endpoints are renamed (as a new one is introduced). Tag importing is fixed to use the 'raw' value rather than the spaceless normalized one. Checksums of files are also checked before import, along with filenames. Logging is added throughout the import process. A button is added to stop the import before it's finished. Refs: #12
|
I've improved the bit where it finds the largest size photo, and for the (usual) case of there being an original available it doesn't need to do an extra API call, so that should help. The rate-limiting is still probably an issue, but I think not a blocker for this patch. I think this is ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix import-all functionality.
Refs: #12