Add headers & query params to websocket handler object #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamohta
force-pushed
the
aditya/add-headers-to-websocket-handler-client
branch
from
e6e1863
to
0467f65
Compare
adityamohta
changed the title
adityamohta
force-pushed
the
aditya/add-headers-to-websocket-handler-client
branch
from
0467f65
to
28129c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think having headers & query params inside the websocket handler object should be a very useful information for servers.
Would be keen to hear opinions of the maintainers, thank you!
Related Issue
#53