small cleanup

Pioreactor · Oct 3, 2023 · c1445c4 · c1445c4
1 parent 18ce5d6
commit c1445c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pioreactor/automations/dosing/base.py b/pioreactor/automations/dosing/base.py
@@ -392,7 +392,7 @@ def execute_io_action(
                 "Not removing enough waste: waste_ml should be greater than sum of dosed ml"
             )
 
-        max_ = 0.75  # arbitrary, but should be some value that the pump is well calibrated for
+        max_ = 0.75  # arbitrary, but should be some value that the pump is well calibrated for. TODO: should this be a constant on the class?
         volumes_moved = SummableDict(waste_ml=0.0, **{p: 0.0 for p in all_pumps_ml})
         source_of_event = f"{self.job_name}:{self.automation_name}"
 

diff --git a/pioreactor/cli/pio.py b/pioreactor/cli/pio.py
@@ -864,7 +864,7 @@ def update_ui(
         """
         Update the PioreactorUI
 
-        Source, if provided, should be a .tar.gz with a top-level dir like pioreactorui-{branch}/
+        Source, if provided, should be a .tar.gz with a top-level dir like pioreactorui-{version}/
         This is what is provided from Github releases.
         """
         logger = create_logger(
@@ -878,8 +878,8 @@ def update_ui(
             version = f"tags/{version}"
 
         if source is not None:
-            assert branch is not None, "branch must be provided with the -b option"
-            version_installed = branch
+            assert version is not None, "version must be provided with the -v option"
+            version_installed = version
 
         elif branch is not None:
             version_installed = quote(branch)