Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
CamDavidsonPilon committed Sep 15, 2023
1 parent 2de64e7 commit bc731e5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pioreactor/automations/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ def execute(self) -> Optional[events.AutomationEvent]:
"""
Overwrite in subclass
"""
raise NotImplementedError("Overwrite in base class")
return None
10 changes: 3 additions & 7 deletions pioreactor/tests/test_dosing_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,8 @@ def test_changing_parameters_over_mqtt_with_unknown_parameter() -> None:
assert any(["garbage" in log["message"] for log in bucket])


def test_pause_in_dosing_automation() -> None:
experiment = "test_pause_in_dosing_automation"
def test_pause_in_dosing_automation_wont_work_use_controller_instead() -> None:
experiment = "test_pause_in_dosing_automation_wont_work_use_controller_instead"
with DosingAutomationJob(
target_growth_rate=0.05,
target_od=1.0,
Expand All @@ -362,10 +362,6 @@ def test_pause_in_dosing_automation() -> None:
pause()
pubsub.publish(f"pioreactor/{unit}/{experiment}/dosing_automation/$state/set", "sleeping")
pause()
assert algo.state == "sleeping"

pubsub.publish(f"pioreactor/{unit}/{experiment}/dosing_automation/$state/set", "ready")
pause()
assert algo.state == "ready"


Expand Down Expand Up @@ -972,8 +968,8 @@ def test_changing_algo_over_mqtt_with_wrong_type_is_okay() -> None:
def test_disconnect_cleanly() -> None:
experiment = "test_disconnect_cleanly"
algo = DosingController(
experiment,
unit,
experiment,
"turbidostat",
target_normalized_od=1.0,
duration=50,
Expand Down

0 comments on commit bc731e5

Please sign in to comment.