Skip to content

Commit

Permalink
rename
Browse files Browse the repository at this point in the history
  • Loading branch information
CamDavidsonPilon committed Jul 17, 2024
1 parent f1fa2f1 commit 0824171
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pioreactor/actions/od_calibration.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def get_name_from_user() -> str:
def get_metadata_from_user() -> tuple[pt.OD600, pt.OD600, pt.mL, pt.PdAngle, pt.PdChannel]:
if config["od_config"]["ir_led_intensity"] == "auto":
raise ValueError(
"Can't use auto with OD calibrations. Change ir_led_intensity in your config.ini to a numeric value (50 is good default)."
"Can't use auto with OD calibrations. Change ir_led_intensity in your config.ini to a numeric value (70 is good default)."
)

initial_od600 = prompt(
Expand Down
6 changes: 4 additions & 2 deletions pioreactor/experiment_profiles/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def expr(self, p) -> bool | float | str:

# HACK
if unit == "unit()":
# technically, common mqtt expressions can use ::job:attr, or unit():job:attr - they are equivilant.
# technically, common mqtt expressions can use ::job:attr, or unit():job:attr - they are equivalent.
unit = self.ENV["unit"]
if job == "job_name()":
job = self.ENV["job_name"]
Expand Down Expand Up @@ -249,7 +249,9 @@ def expr(self, p) -> bool | float | str:
return convert_string(value)

else:
raise MQTTValueError(f"{data_string} does not exist for experiment `{experiment}`")
raise MQTTValueError(
f"{':'.join([unit, job, setting_keys])} does not exist for experiment `{experiment}`"
)


def parse_profile_expression_to_bool(profile_string: str, env=None) -> bool:
Expand Down
2 changes: 1 addition & 1 deletion pioreactor/tests/test_led_automation.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from pioreactor import structs
from pioreactor.actions.led_intensity import lock_leds_temporarily
from pioreactor.automations import events
from pioreactor.automations.led import Silent
from pioreactor.automations.led import LEDSilent as Silent
from pioreactor.automations.led.light_dark_cycle import LightDarkCycle
from pioreactor.utils import local_intermittent_storage
from pioreactor.utils.timing import current_utc_datetime
Expand Down

0 comments on commit 0824171

Please sign in to comment.