Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs): fix pipeline and templates for custom builder image support #1315

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 6, 2024

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind November 6, 2024 10:45
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the changes in this PR are related to fixing a pipeline and templates for custom builder image support. The changes include adding a new parameter named force-builder-image to the pingcap-build-package-darwin.yaml pipeline file and _build-component-all-platforms.yaml template file.

The force-builder-image parameter is used to specify the builder image to use for building binaries by force. If this parameter is empty, the task will complete one from the configuration in artifacts.git repo.

Potential problems:

  • It is not clear from the PR description what issues the changes are fixing, and there is no reference to any related issues.
  • It is also not clear why the force-builder-image parameter is needed and how it will be used in the pipelines and templates.
  • There may be other changes made in the code that are not included in the diff, so it is hard to tell if there are any unintended side effects.

Fixing suggestions:

  • The PR description should provide more context about the changes, including the issues they are fixing, and any other relevant information.
  • The purpose and usage of the force-builder-image parameter should be explained in the PR description or in comments in the code.
  • It would be helpful to have some documentation for the pipeline and template files to make it easier for others to understand and modify them in the future.
  • It would also be good to do some testing to make sure the changes work as intended and do not introduce any new issues.

Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot bot added the size/S label Nov 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5dee7ea into main Nov 6, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/custom-builder-image branch November 6, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant