Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/triggers): fix fake github triggers #1314

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 6, 2024

The cloud events can not support extension header
with "-" chars, only support a-z and A-Z and
number chars.

Signed-off-by: wuhuizuo [email protected]

The cloud events can not support extension header
with "-" chars, only support a-z and A-Z and
number chars.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind November 6, 2024 09:37
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title, the changes made in this pull request are to fix the fake Github triggers in the tekton configuration files. The changes are made to the fake-github-branch-push.yaml, fake-github-pr.yaml, and fake-github-tag-create.yaml files.

The changes made are to replace the '-' character in the ce-param-builder-image header with a lowercase 'b' in ce-paramBuilderImage as the cloud events do not support '-' characters in the header.

There are no potential problems with these changes as they are only fixing a header issue that could cause problems in the future.

The suggestion for fixing these issues is already implemented in the pull request. So, it looks good to merge.

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 6, 2024
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Nov 6, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 81a91ad into main Nov 6, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/refactor-custom-builder-image-support branch November 6, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant