Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/triggers/bindings): fix binding github-pr #1310

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 5, 2024

Comment the pr-author in the binding github-pr to compatible with TiBuild stories.

Signed-off-by: wuhuizuo [email protected]

Comment the `pr-author` in the binding `github-pr` to compatible with TiBuild stories.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind November 5, 2024 07:04
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the pull request, it appears that the author is fixing an issue with a binding called github-pr in the apps/prod/tekton/configs/triggers/bindings directory. The change involves commenting out the pr-author field to make the binding compatible with TiBuild stories.

There do not seem to be any potential problems with this change, as it is a simple modification to a specific field in the YAML file. However, it would be helpful if the author had provided more context on why this change was necessary and how it impacts the overall pipeline.

As for fixing suggestions, it would be good to clarify in the PR description why the pr-author field needed to be commented out and how it will impact the pipeline. Additionally, it would be useful to include any relevant documentation or reference materials related to this change.

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 5, 2024
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Nov 5, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit a2d66b4 into main Nov 5, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tekton-trigger-binding-github-pr branch November 5, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant