Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boskos-resources.yaml #1306

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update boskos-resources.yaml #1306

merged 1 commit into from
Nov 1, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 1, 2024

remove resource darwin-arm64-1

remove resource `darwin-arm64-1`
@ti-chi-bot ti-chi-bot bot requested a review from purelind November 1, 2024 02:31
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it looks like the only change made is the removal of the darwin-arm64-1 resource from the boskos-resources.yaml file. The diff shows that the resource has been commented out.

There are a few potential problems that can arise from this change. Firstly, if any jobs or pipelines were using the darwin-arm64-1 resource, they will fail since the resource has been removed. Additionally, if there are any scripts or configurations that assume the presence of the darwin-arm64-1 resource, they will also fail.

To fix this, it's important to ensure that any jobs or pipelines using the darwin-arm64-1 resource are updated to use a different resource. It may also be necessary to update any scripts or configurations that assume the presence of the resource. If the removal of the resource was intentional and there are no dependencies on it, then the change can be approved.

@ti-chi-bot ti-chi-bot bot added the size/S label Nov 1, 2024
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Nov 1, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 1, 2024
@ti-chi-bot ti-chi-bot bot merged commit 214b705 into main Nov 1, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wuhuizuo-patch-2 branch November 1, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant