refactoring code for better vectorization #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
train/dev/test datasets
* add unicode fixing to question preprocessing * add prompts * dependency
* Update RM * Small formatting fix
* Update dan.py * Update rnn.py * Update elmo.py * Update rnn.py * Update dan.py * Update elmo.py
* Update README.md * Add files via upload * Add back elastic search instructions * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you very much for your excellent work in qb.
I am a graduate student at the University of Colorado, studying the best practices of evolving ML codes. From our research, one of the most common evolution best practice in ML code is the migration of loop-based computations to vectorization, since this usually improves performance and code quality. We made the following changes in batchflow, which remove the FOR loop and use
.join(). I carefully checked the modification to ensure that it does not break the code. I will gladly contribute. Please help me to merge this.