feat: Add fullscreen support to glfw code path#144
Open
RealDanTheMan wants to merge 1 commit intoPilotLightTech:masterfrom
Open
feat: Add fullscreen support to glfw code path#144RealDanTheMan wants to merge 1 commit intoPilotLightTech:masterfrom
RealDanTheMan wants to merge 1 commit intoPilotLightTech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented fullscreen support (#133) for experimental builds utilizing the GLFW code path.
Changes
Monitor Selection: Added ability for users/app code to specify a target monitor, useful for multi-screen setups.
Fallback Logic: If monitor or video settings fail to resolve during initialization, the window defaults to a 320x200 resolution.
Window Mode: Opted for borderless window rather than exclusive fullscreen.
Notes
Desktop Integration: The window is configured not to draw over system menu bars (Linux/macOS).
UX Rationale: I chose borderless/non-exclusive mode to provide a smoother multitasking experience on modern desktops.
Note: I am open to switching to exclusive fullscreen if that's the project preference
Example running on MacOS