about page #1533
about page #1533
Conversation
varCepheid
added
enhancement
|
I put in a version number, but I can easily take that out if we don't like it. Also, whoever reviews this, please proofread the text. |
There was a problem hiding this comment.
@varCepheid Thanks for making this PR! I've wanted to have some sort of homepage/intro page for a long time!
calebeby
added
the
needs work
replaced grid with constrained widths added semantic HTML tags linked email address added header tag
varCepheid
added
question
There was a problem hiding this comment.
@varCepheid Thanks for making this about page, it is definitely something that I've wanted to exist for a long time but was never able to prioritize. This PR is getting pretty close to being ready!
calebeby
added
the
needs work
varCepheid
removed
the
needs work
src/routes/about.tsx
Outdated
| <p> | ||
| <strong>{"It's really easy to get started with Peregrine."}</strong> | ||
| {' Have a team captain or coach send an email to '} | ||
| <a href="mailto:[email protected]"> [email protected] </a> |
There was a problem hiding this comment.
The space is linked here, which I think was not intended:
| <a href="mailto:[email protected]"> [email protected] </a> | |
| <a href="mailto:[email protected]">[email protected]</a> |
(not sure why the space after is linked but not the space before. Usually for HTML elements you do not want to have spaces right inside of the element declaration, so I'd suggest making this kind of change throughout this file.
src/routes/about.tsx
Outdated
| } | ||
| </strong> | ||
| {'at '} | ||
| <a href="mailto:[email protected]"> [email protected]. </a> |
There was a problem hiding this comment.
Nit: The ending period is linked, which is not part of the email:
| <a href="mailto:[email protected]"> [email protected]. </a> | |
| <a href="mailto:[email protected]">[email protected]</a>{'.'} |
(not sure how prettier will want to format this)
* created about page and added link from sidebar menu * created the route * changed export to default * added more substance to about page * added text and styling * changed to grid layout and some editing * aesthetic changes * revisions to the about blurb * updated about page replaced grid with constrained widths added semantic HTML tags linked email address added header tag * fixed text width, header margins * padding and margin changes * editing and minor changes * replaced text with embedded expressions * adjusted width parameters to make text narrower * formatting changes * convention & hyperlink nits --------- Co-authored-by: Caleb Eby <[email protected]> Co-authored-by: Caleb Eby <[email protected]>
closes #1531
This PR creates an about page, linked from the sidebar menu, that has information about what Peregrine is, how teams can start using it or get help using it, and some useful links and contact information.