Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change back button to last viewed page #1522
base: dev
Are you sure you want to change the base?
Change back button to last viewed page #1522
Changes from 35 commits
ec32029
71595ac
2fb4e73
9abd4c7
4c1b581
5a142a7
662e43f
3c7179f
1410018
4926a33
5ad746c
b9ba663
583597a
7d9dee3
266f440
81d2b22
43fdc9d
798549b
0258408
a25bce2
c7b7f48
7d96123
ac0d0f8
48752ef
845d146
79dff07
5f8c4a9
6e1116b
d0642c7
9458155
3f90658
5c613a6
6d69601
68b8bd4
5e2bbc4
ee45d65
50d9762
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why you removed this attribute. Having a key attribute helps Preact with diffing, so that it knows the difference between when items were changed, added, reordered, or removed. I think there was some weird edge case where when this page rerendered (due to the newestIncompleteMatch switching), it might have reset the input on the event matches list, or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because the
MatchDetailsCard
component doesn't havekey
as a property. I don't know what it's passing into.